Fix state loading for warm state runs - #25
Merged
Conversation
Author
|
I tested in the RTE and confirmed that the warm start states were properly configured to load the correct states. |
Author
|
Tested by Richard in ngenCERF and confirmed to produce valid results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An issue was discovered where the warm start runs were not properly loading the cold start state (first warm start iteration) or previous warm start saved states (subsequent warm start iterations). This updates the run_hindcast workflow to properly track which state should be loaded for each warm start run and supplies it to the msw-mgr via the load_state_from argument.