Add hindcast orchestration logger to hindcasting workflow - #41
Merged
Conversation
Author
|
Tested by Carolyn on ngenCERF and confirmed that the new log file was viewable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
hindcast_loggertorun_hindcast()so all orchestration-level messages are logged to a singlefcst_mgr_hindcast.logfile at the hindcast run's root folder in/Hindcast_Run/instead of leaking into individual run log files. Previously, messages logged between runs (e.g. warm start initialized for cycle 3) were incorrectly appended to the prior run's log file because all hindcast logging shared a single fcst-mgr global logger. Since the hindcast root path is not created until the firstbuild_fcst()call returns, early messages are buffered and flushed tohindcast_loggeronce it has been initialized.