Jwade logs creation - #86
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent merges to nwm-ewts and nwm-fcst-mgr resulted in instances where log files were not being properly created by the ewts. This PR adds functionality to the msw-mgr to create the work_dir/logs/ folder if it does not yet exist, which resolves the log folder creation warning.
Additionally, there was a missing forecast return in the msw-mgr, which is needed to be compatible with a recent merge to the fcst-mgr: NGWPC/nwm-fcst-mgr#23. This functionality was initially intended to be introduced in this [PR] (#58), but it is needed in development early to work with the current development of the fcst-mgr.