Add Hindcast Workflow - #24
Conversation
…, and warm_start to match that of other run types.
| @@ -199,8 +214,8 @@ def configure_ngen_log(self, rb: RealizationBuilder) -> None: | |||
|
|
|||
| if rb.run_type in ("default", "checkpoint", "regionalization"): | |||
There was a problem hiding this comment.
Given that these encompass all run types, coud we just set fallback_log_dir = str(rb.workdir) without a check for run type?
There was a problem hiding this comment.
Yes, I kept the current conditional flow in case there may be some need for the others to be separated later, but currently there is no need for them to be separated.
There was a problem hiding this comment.
I say we just condense it to a single line.
| f"Hindcast _num_iterations must be str representation of an integer, but got: {repr(_num_iterations)}" | ||
| ) | ||
| ) | ||
| self.hc_cycle_interval = int(_cycle_interval) |
There was a problem hiding this comment.
If there is an error appended when matching the cycle_interval in L297, the int(_cycle_interval) here will likely fail before those errors can be logged properly.
| ) | ||
| ) | ||
|
|
||
| if self.hc_cold_start_state: |
There was a problem hiding this comment.
Already discussed with Max, but we should be able to hook up cold starts to hindcasts in the RTE.
There was a problem hiding this comment.
I was reading a stale note too literally in a ticket -- yes this should be easy to wire up to existing coldstart/warmstart support for starting a hindcast cycle.
There was a problem hiding this comment.
Implemented via cold_start_state=cfg.load_state_from
jswade-rtx
left a comment
There was a problem hiding this comment.
Tested state load for hindcasting and parallel processing for hindcasting. Looks good to me.
|
Marging after updating the example calls to include |
Adds a new way of calling nwm-fcst-mgr's
run_hindcastfunction as a generator of RealizationBuilder instances (skipping ngen run) to allow nwm-rte itself to run ngen on each realization yielded, through the formalNgenRunnerAsyncwrapper.This requires: NGWPC/nwm-fcst-mgr#43
Additions
-hc, --hindcast-argswhich contains 2 parts:run_suite.sh:Removals
Changes
rb.work_dirinstead of torb.input_dir, by default.ForecastExecutionManager.preprocess.Testing
Screenshots
Notes
Todos
Checklist
Testing checklist
Target Environment support
Accessibility
Other