Skip to content

Conversation

@jacribeiro
Copy link

Closes #323

@jacribeiro jacribeiro requested a review from Naapperas December 6, 2023 15:33
@render
Copy link

render bot commented Dec 6, 2023

Copy link
Collaborator

@Naapperas Naapperas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, just missing some tests @jacribeiro

@jacribeiro jacribeiro requested a review from Naapperas December 8, 2023 10:47
@codecov
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (81bce7c) 90.33% compared to head (9fe28ba) 90.39%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #342      +/-   ##
===========================================
+ Coverage    90.33%   90.39%   +0.06%     
===========================================
  Files           54       54              
  Lines         1469     1468       -1     
  Branches       245      245              
===========================================
  Hits          1327     1327              
+ Misses         137      136       -1     
  Partials         5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@FranciscoCardoso913 FranciscoCardoso913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to merge, nice job : )

Copy link
Collaborator

@Naapperas Naapperas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, don´t forget to rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move "Company offers" route to another place

4 participants