aligned text with button #314
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #314 +/- ##
========================================
Coverage 88.97% 88.97%
========================================
Files 175 175
Lines 3311 3312 +1
Branches 834 834
========================================
+ Hits 2946 2947 +1
Misses 365 365 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Process-ing
requested changes
Mar 13, 2023
Contributor
Process-ing
left a comment
Process-ing
left a comment
There was a problem hiding this comment.
Everything seems great! Though, there's a teeny-tiny issue that I need to mention.
| aria-label={`Remove Entry ${i}`} | ||
| onClick={onClick} | ||
| className={classes.buttom} | ||
| disabled={disabled} |
Contributor
There was a problem hiding this comment.
buttom is triggering my OCD.
| export default makeStyles(() => ({ | ||
| buttom: { | ||
| bottom: "10px", | ||
| }, |
Collaborator
|
@letziou updates on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the meeting I removed the textFieldProps={{ multiline: true }} option from the requirements textField and then adjusted the position of the remove entry button to align with the text.
Closes #262