Skip to content

初期フローを作成した #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Dec 19, 2024
Merged

初期フローを作成した #115

merged 13 commits into from
Dec 19, 2024

Conversation

Konayashi
Copy link
Collaborator

やったこと

#72 #74 #75 #78 #80
これらの初期フロー画面の実装

やってないこと

データストアの動作が未確認

スクリーンショット・動作確認

Previewを見てRunした結果、画面遷移や名前の入力、アイコンのための画像の選択ができた。

自己評価

出来を 10 点満点で自己評価:

6点

  • 実装できたのでチェックして欲しい。
  • 心配なところがいくつかある。
    名前やアイコンをデータストアに入力する際にどちらか一つでも入力せずに「次へ」ボタンを押すとアプリがクラッシュする。
  • あまり理解できていないが issue などに書いてあるとおり やった。
  • その他(下に記入)

その他

  • レビュワーへの参考情報(気になった点や注意点などあれば〜)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

ktlint

🚫 [ktlint] standard:op-spacing reported by reviewdog 🐶
Missing spacing after "="


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (18) (should be 20)


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (22) (should be 24)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (22) (should be 24)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (18) (should be 16)


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (16) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (16) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (12) (should be 16)


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"


🚫 [ktlint] standard:no-consecutive-blank-lines reported by reviewdog 🐶
Needless blank line(s)


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:curly-spacing reported by reviewdog 🐶
Missing spacing before "{"


🚫 [ktlint] standard:wrapping reported by reviewdog 🐶
Missing newline after "("

Text(text = "(ただし歩かない期間が長いと",


🚫 [ktlint] standard:argument-list-wrapping reported by reviewdog 🐶
Argument should be on a separate line (unless all arguments can fit a single line)

Text(text = "(ただし歩かない期間が長いと",


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:comma-spacing reported by reviewdog 🐶
Missing spacing after ","


🚫 [ktlint] standard:wrapping reported by reviewdog 🐶
Missing newline after "("

Text(text = "逆に太ってしまうことも...",


🚫 [ktlint] standard:argument-list-wrapping reported by reviewdog 🐶
Argument should be on a separate line (unless all arguments can fit a single line)

Text(text = "逆に太ってしまうことも...",


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:comma-spacing reported by reviewdog 🐶
Missing spacing after ","


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"


🚫 [ktlint] standard:curly-spacing reported by reviewdog 🐶
Missing spacing before "{"


🚫 [ktlint] standard:function-start-of-body-spacing reported by reviewdog 🐶
Expected a single white space before start of function body


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Expected a single space before body block


🚫 [ktlint] standard:import-ordering reported by reviewdog 🐶
Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end


🚫 [ktlint] standard:no-consecutive-blank-lines reported by reviewdog 🐶
Needless blank line(s)


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
No whitespace expected between opening parenthesis and first parameter name


🚫 [ktlint] standard:wrapping reported by reviewdog 🐶
Missing newline before ")"


🚫 [ktlint] standard:parameter-list-wrapping reported by reviewdog 🐶
Missing newline before ")"


🚫 [ktlint] standard:trailing-comma-on-declaration-site reported by reviewdog 🐶
Missing trailing comma before ")"


🚫 [ktlint] standard:colon-spacing reported by reviewdog 🐶
Unexpected spacing before ":"

val viewModel : UserProfileViewModel = viewModel()


🚫 [ktlint] standard:colon-spacing reported by reviewdog 🐶
Unexpected spacing before ":"


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line

val launcher = rememberLauncherForActivityResult(contract = ActivityResultContracts.GetContent()) {uri ->


🚫 [ktlint] standard:curly-spacing reported by reviewdog 🐶
Missing spacing after "{"

val launcher = rememberLauncherForActivityResult(contract = ActivityResultContracts.GetContent()) {uri ->


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (12) (should be 8)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (16) (should be 12)


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (12) (should be 8)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (16) (should be 12)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)

horizontalAlignment = Alignment.CenterHorizontally,


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (16) (should be 12)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:paren-spacing reported by reviewdog 🐶
Unexpected spacing after "("


🚫 [ktlint] standard:curly-spacing reported by reviewdog 🐶
Missing spacing before "{"


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:wrapping reported by reviewdog 🐶
Missing newline after "("


🚫 [ktlint] standard:argument-list-wrapping reported by reviewdog 🐶
Argument should be on a separate line (unless all arguments can fit a single line)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (28) (should be 24)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (28) (should be 24)


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (32) (should be 28)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (32) (should be 28)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (32) (should be 28)


🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:curly-spacing reported by reviewdog 🐶
Missing spacing after "}"


🚫 [ktlint] standard:curly-spacing reported by reviewdog 🐶
Missing spacing before "{"


🚫 [ktlint] standard:keyword-spacing reported by reviewdog 🐶
Missing spacing after "else"


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"


🚫 [ktlint] standard:wrapping reported by reviewdog 🐶
Missing newline before "}"


🚫 [ktlint] standard:curly-spacing reported by reviewdog 🐶
Missing spacing before "}"


🚫 [ktlint] standard:statement-wrapping reported by reviewdog 🐶
Missing newline before '}'


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)

onValueChange = { newValue -> text.value = newValue },


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)

placeholder = { Text(text = "名前をここに入力してね") },


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:wrapping reported by reviewdog 🐶
Missing newline after "("


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (28) (should be 32)


🚫 [ktlint] standard:wrapping reported by reviewdog 🐶
Missing newline before ")"


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (28) (should be 24)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (28) (should be 24)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:wrapping reported by reviewdog 🐶
Missing newline after "("


🚫 [ktlint] standard:argument-list-wrapping reported by reviewdog 🐶
Argument should be on a separate line (unless all arguments can fit a single line)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (28) (should be 24)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (28) (should be 24)


🚫 [ktlint] standard:wrapping reported by reviewdog 🐶
Missing newline before ")"


🚫 [ktlint] standard:argument-list-wrapping reported by reviewdog 🐶
Missing newline before ")"


🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:wrapping reported by reviewdog 🐶
Missing newline after "("


🚫 [ktlint] standard:argument-list-wrapping reported by reviewdog 🐶
Argument should be on a separate line (unless all arguments can fit a single line)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (28) (should be 24)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (28) (should be 24)


🚫 [ktlint] standard:wrapping reported by reviewdog 🐶
Missing newline before ")"


🚫 [ktlint] standard:argument-list-wrapping reported by reviewdog 🐶
Missing newline before ")"


🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (16) (should be 12)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (16) (should be 12)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)

nextDestination = "InitialFlow/8/${text.value}",


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (28) (should be 24)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (32) (should be 28)

viewModel.saveNameToDateStore(context, text.value)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (32) (should be 28)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (36) (should be 32)

viewModel.saveUserIconToDateStore(context, it.toString())


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (32) (should be 28)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (28) (should be 24)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (16) (should be 12)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (16) (should be 12)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (16) (should be 12)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (16) (should be 12)


🚫 [ktlint] standard:no-consecutive-blank-lines reported by reviewdog 🐶
Needless blank line(s)


🚫 [ktlint] standard:curly-spacing reported by reviewdog 🐶
Missing spacing before "{"


🚫 [ktlint] standard:class-signature reported by reviewdog 🐶
Expected a single space before class body


🚫 [ktlint] standard:no-consecutive-blank-lines reported by reviewdog 🐶
Needless blank line(s)


🚫 [ktlint] standard:curly-spacing reported by reviewdog 🐶
Missing spacing before "{"


🚫 [ktlint] standard:function-start-of-body-spacing reported by reviewdog 🐶
Expected a single white space before start of function body


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Expected a single space before body block


🚫 [ktlint] standard:function-literal reported by reviewdog 🐶
No newline expected before parameter


🚫 [ktlint] standard:curly-spacing reported by reviewdog 🐶
Missing spacing before "{"


🚫 [ktlint] standard:function-start-of-body-spacing reported by reviewdog 🐶
Expected a single white space before start of function body


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Expected a single space before body block


🚫 [ktlint] standard:function-literal reported by reviewdog 🐶
No newline expected before parameter


🚫 [ktlint] standard:no-consecutive-blank-lines reported by reviewdog 🐶
Needless blank line(s)


🚫 [ktlint] standard:curly-spacing reported by reviewdog 🐶
Missing spacing before "{"


🚫 [ktlint] standard:function-start-of-body-spacing reported by reviewdog 🐶
Expected a single white space before start of function body


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Expected a single space before body block


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:wrapping reported by reviewdog 🐶
Missing newline after "("

Text(text = "達成がすぐにわかるよ!",


🚫 [ktlint] standard:argument-list-wrapping reported by reviewdog 🐶
Argument should be on a separate line (unless all arguments can fit a single line)

Text(text = "達成がすぐにわかるよ!",


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"


🚫 [ktlint] standard:curly-spacing reported by reviewdog 🐶
Missing spacing before "{"


🚫 [ktlint] standard:function-start-of-body-spacing reported by reviewdog 🐶
Expected a single white space before start of function body


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Expected a single space before body block


🚫 [ktlint] standard:no-consecutive-blank-lines reported by reviewdog 🐶
Needless blank line(s)


🚫 [ktlint] standard:trailing-comma-on-declaration-site reported by reviewdog 🐶
Missing trailing comma before ")"

Copy link

github-actions bot commented Nov 7, 2024

Tip

デバッグビルドに成功しました

Copy link

github-actions bot commented Nov 7, 2024

Tip

リリースビルドに成功しました

@TBSten
Copy link
Collaborator

TBSten commented Nov 14, 2024

@Konayashi
ターミナルで 以下を実行して自動フォーマットしてください 🙏

./gradlew ktlintFormat

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

ktlint

🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"


🚫 [ktlint] standard:no-consecutive-blank-lines reported by reviewdog 🐶
Needless blank line(s)


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:curly-spacing reported by reviewdog 🐶
Missing spacing before "{"


🚫 [ktlint] standard:wrapping reported by reviewdog 🐶
Missing newline after "("

Text(text = "(ただし歩かない期間が長いと",


🚫 [ktlint] standard:argument-list-wrapping reported by reviewdog 🐶
Argument should be on a separate line (unless all arguments can fit a single line)

Text(text = "(ただし歩かない期間が長いと",


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:comma-spacing reported by reviewdog 🐶
Missing spacing after ","


🚫 [ktlint] standard:wrapping reported by reviewdog 🐶
Missing newline after "("

Text(text = "逆に太ってしまうことも...",


🚫 [ktlint] standard:argument-list-wrapping reported by reviewdog 🐶
Argument should be on a separate line (unless all arguments can fit a single line)

Text(text = "逆に太ってしまうことも...",


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:comma-spacing reported by reviewdog 🐶
Missing spacing after ","


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"


🚫 [ktlint] standard:curly-spacing reported by reviewdog 🐶
Missing spacing before "{"


🚫 [ktlint] standard:function-start-of-body-spacing reported by reviewdog 🐶
Expected a single white space before start of function body


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Expected a single space before body block


🚫 [ktlint] standard:import-ordering reported by reviewdog 🐶
Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end


🚫 [ktlint] standard:no-consecutive-blank-lines reported by reviewdog 🐶
Needless blank line(s)


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
No whitespace expected between opening parenthesis and first parameter name


🚫 [ktlint] standard:wrapping reported by reviewdog 🐶
Missing newline before ")"


🚫 [ktlint] standard:parameter-list-wrapping reported by reviewdog 🐶
Missing newline before ")"


🚫 [ktlint] standard:trailing-comma-on-declaration-site reported by reviewdog 🐶
Missing trailing comma before ")"


🚫 [ktlint] standard:colon-spacing reported by reviewdog 🐶
Unexpected spacing before ":"

val viewModel : UserProfileViewModel = viewModel()


🚫 [ktlint] standard:colon-spacing reported by reviewdog 🐶
Unexpected spacing before ":"


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line

val launcher = rememberLauncherForActivityResult(contract = ActivityResultContracts.GetContent()) {uri ->


🚫 [ktlint] standard:curly-spacing reported by reviewdog 🐶
Missing spacing after "{"

val launcher = rememberLauncherForActivityResult(contract = ActivityResultContracts.GetContent()) {uri ->


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (12) (should be 8)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (16) (should be 12)


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (12) (should be 8)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (16) (should be 12)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)

horizontalAlignment = Alignment.CenterHorizontally,


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (16) (should be 12)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:paren-spacing reported by reviewdog 🐶
Unexpected spacing after "("


🚫 [ktlint] standard:curly-spacing reported by reviewdog 🐶
Missing spacing before "{"


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:wrapping reported by reviewdog 🐶
Missing newline after "("


🚫 [ktlint] standard:argument-list-wrapping reported by reviewdog 🐶
Argument should be on a separate line (unless all arguments can fit a single line)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (28) (should be 24)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (28) (should be 24)


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (32) (should be 28)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (32) (should be 28)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (32) (should be 28)


🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:curly-spacing reported by reviewdog 🐶
Missing spacing after "}"


🚫 [ktlint] standard:curly-spacing reported by reviewdog 🐶
Missing spacing before "{"


🚫 [ktlint] standard:keyword-spacing reported by reviewdog 🐶
Missing spacing after "else"


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"


🚫 [ktlint] standard:wrapping reported by reviewdog 🐶
Missing newline before "}"


🚫 [ktlint] standard:curly-spacing reported by reviewdog 🐶
Missing spacing before "}"


🚫 [ktlint] standard:statement-wrapping reported by reviewdog 🐶
Missing newline before '}'


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)

onValueChange = { newValue -> text.value = newValue },


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)

placeholder = { Text(text = "名前をここに入力してね") },


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (28) (should be 24)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (28) (should be 24)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:wrapping reported by reviewdog 🐶
Missing newline after "("


🚫 [ktlint] standard:argument-list-wrapping reported by reviewdog 🐶
Argument should be on a separate line (unless all arguments can fit a single line)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (28) (should be 24)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (28) (should be 24)


🚫 [ktlint] standard:wrapping reported by reviewdog 🐶
Missing newline before ")"


🚫 [ktlint] standard:argument-list-wrapping reported by reviewdog 🐶
Missing newline before ")"


🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:wrapping reported by reviewdog 🐶
Missing newline after "("


🚫 [ktlint] standard:argument-list-wrapping reported by reviewdog 🐶
Argument should be on a separate line (unless all arguments can fit a single line)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (28) (should be 24)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (28) (should be 24)


🚫 [ktlint] standard:wrapping reported by reviewdog 🐶
Missing newline before ")"


🚫 [ktlint] standard:argument-list-wrapping reported by reviewdog 🐶
Missing newline before ")"


🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (16) (should be 12)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (16) (should be 12)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)

nextDestination = "initialFlow/8/${text.value}",


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (28) (should be 24)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (32) (should be 28)

viewModel.saveNameToDateStore(context, text.value)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (32) (should be 28)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (36) (should be 32)

viewModel.saveUserIconToDateStore(context, it.toString())


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (32) (should be 28)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (28) (should be 24)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (16) (should be 12)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (16) (should be 12)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (16) (should be 12)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (20) (should be 16)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (16) (should be 12)


🚫 [ktlint] standard:no-consecutive-blank-lines reported by reviewdog 🐶
Needless blank line(s)


🚫 [ktlint] standard:curly-spacing reported by reviewdog 🐶
Missing spacing before "{"


🚫 [ktlint] standard:class-signature reported by reviewdog 🐶
Expected a single space before class body


🚫 [ktlint] standard:no-consecutive-blank-lines reported by reviewdog 🐶
Needless blank line(s)


🚫 [ktlint] standard:curly-spacing reported by reviewdog 🐶
Missing spacing before "{"


🚫 [ktlint] standard:function-start-of-body-spacing reported by reviewdog 🐶
Expected a single white space before start of function body


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Expected a single space before body block


🚫 [ktlint] standard:function-literal reported by reviewdog 🐶
No newline expected before parameter


🚫 [ktlint] standard:curly-spacing reported by reviewdog 🐶
Missing spacing before "{"


🚫 [ktlint] standard:function-start-of-body-spacing reported by reviewdog 🐶
Expected a single white space before start of function body


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Expected a single space before body block


🚫 [ktlint] standard:function-literal reported by reviewdog 🐶
No newline expected before parameter


🚫 [ktlint] standard:no-consecutive-blank-lines reported by reviewdog 🐶
Needless blank line(s)


🚫 [ktlint] standard:curly-spacing reported by reviewdog 🐶
Missing spacing before "{"


🚫 [ktlint] standard:function-start-of-body-spacing reported by reviewdog 🐶
Expected a single white space before start of function body


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Expected a single space before body block


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:wrapping reported by reviewdog 🐶
Missing newline after "("

Text(text = "達成がすぐにわかるよ!",


🚫 [ktlint] standard:argument-list-wrapping reported by reviewdog 🐶
Argument should be on a separate line (unless all arguments can fit a single line)

Text(text = "達成がすぐにわかるよ!",


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"


🚫 [ktlint] standard:multiline-expression-wrapping reported by reviewdog 🐶
A multiline expression should start on a new line


🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"


🚫 [ktlint] standard:curly-spacing reported by reviewdog 🐶
Missing spacing before "{"


🚫 [ktlint] standard:function-start-of-body-spacing reported by reviewdog 🐶
Expected a single white space before start of function body


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Expected a single space before body block


🚫 [ktlint] standard:no-consecutive-blank-lines reported by reviewdog 🐶
Needless blank line(s)


🚫 [ktlint] standard:trailing-comma-on-declaration-site reported by reviewdog 🐶
Missing trailing comma before ")"


🚫 [ktlint] standard:wrapping reported by reviewdog 🐶
Missing newline after "("


🚫 [ktlint] standard:argument-list-wrapping reported by reviewdog 🐶
Argument should be on a separate line (unless all arguments can fit a single line)


🚫 [ktlint] standard:wrapping reported by reviewdog 🐶
Missing newline before ")"


🚫 [ktlint] standard:argument-list-wrapping reported by reviewdog 🐶
Missing newline before ")"


🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"

Copy link
Collaborator

@TBSten TBSten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@nekomoti22 nekomoti22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nekomoti_LGTM2

Copy link
Collaborator

@TBSten TBSten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

先にApprove 押しておきます

@Konayashi Konayashi merged commit 4b0a0b3 into main Dec 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants