Skip to content

Github ActionのArtifactをv4にしました #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Conversation

nekomoti22
Copy link
Collaborator

やったこと

Githubのmain.yamlの
uses: actions/upload-artifact@v2をv4に変更しました

やってないこと

スクリーンショット・動作確認

mergeできたら変更成功のような気がする

自己評価

出来を 10 点満点で自己評価:

8 点

  • 実装できたのでチェックして欲しい。
  • 心配なところがいくつかある。
  • あまり理解できていないが issue などに書いてあるとおり やった。
  • その他(下に記入)

その他

  • レビュワーへの参考情報(気になった点や注意点などあれば〜)

Copy link

github-actions bot commented Jan 14, 2025

Tip

デバッグビルドに成功しました

Copy link

github-actions bot commented Jan 14, 2025

Tip

リリースビルドに成功しました

Copy link
Collaborator

@TBSten TBSten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コメントはしたけどLGTMです

# チェックアウト
- uses: actions/checkout@v2
# チェックアウト
- uses: actions/checkout@v2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nits]
ついでにここも v4 にしてくれると嬉しいです
リリースノート: https://github.com/actions/checkout/releases

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

da0b650 にて解決済み

# チェックアウト
- uses: actions/checkout@v2
# チェックアウト
- uses: actions/checkout@v2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nits]
ここも同様

Copy link
Collaborator Author

@nekomoti22 nekomoti22 Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

da0b650
にて解決ずみ

Copy link
Collaborator

@Konayashi Konayashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

大丈夫そうです!

@nekomoti22 nekomoti22 merged commit b065d0d into main Jan 30, 2025
1 check passed
@nekomoti22 nekomoti22 deleted the feature/issue-52 branch March 13, 2025 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants