-
Notifications
You must be signed in to change notification settings - Fork 0
Github ActionのArtifactをv4にしました #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tip デバッグビルドに成功しました |
Tip リリースビルドに成功しました |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.github/workflows/main.yml
Outdated
# チェックアウト | ||
- uses: actions/checkout@v2 | ||
# チェックアウト | ||
- uses: actions/checkout@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nits]
ついでにここも v4 にしてくれると嬉しいです
リリースノート: https://github.com/actions/checkout/releases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
da0b650 にて解決済み
.github/workflows/main.yml
Outdated
# チェックアウト | ||
- uses: actions/checkout@v2 | ||
# チェックアウト | ||
- uses: actions/checkout@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nits]
ここも同様
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
da0b650
にて解決ずみ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
大丈夫そうです!
やったこと
Githubのmain.yamlの
uses: actions/upload-artifact@v2をv4に変更しました
やってないこと
スクリーンショット・動作確認
mergeできたら変更成功のような気がする
自己評価
出来を 10 点満点で自己評価:
8 点
その他