Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

通知の実装 #142

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

通知の実装 #142

wants to merge 8 commits into from

Conversation

Konayashi
Copy link
Collaborator

@Konayashi Konayashi commented Feb 13, 2025 •
edited by TBSten
Loading

やったこと

通知の基盤、2種類の通知チャンネルと細かな通知の内容を作成した。

Close #127
Close #128

やってないこと

通知に使用しているくまの名前をユーザの入力したものから参照できていない。通知の動作確認が十分じゃない。

スクリーンショット・動作確認

自己評価

出来を 10 点満点で自己評価:

5 点

  • 実装できたのでチェックして欲しい。
  • 心配なところがいくつかある。
  • あまり理解できていないが issue などに書いてあるとおり やった。
  • その他（下に記入）

その他

通知のタイトルやテキスト等の内容も確認してほしい

  • レビュワーへの参考情報（気になった点や注意点などあれば〜）

TBSten
TBSten approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@TBSten TBSten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

app/src/main/java/com/example/runningavater/notification/RegularlyNotification.kt
bearname: String,
) {
// 　ランダムなメッセージのリスト
val messages =
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[good]
kawaii

@TBSten TBSten changed the title Feature/issue 127 通知の実装 Feb 23, 2025
nekomoti22
nekomoti22 approved these changes Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@nekomoti22 nekomoti22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LGTM]いっぱい書いたね

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 9, 2025 •
edited
Loading

Tip

デバッグビルドに成功しました

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 9, 2025 •
edited
Loading

Tip

リリースビルドに成功しました

@TBSten TBSten requested a review from Copilot March 13, 2025 13:24
Copilot
Copilot AI reviewed Mar 13, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@TBSten TBSten TBSten approved these changes

@nekomoti22 nekomoti22 nekomoti22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Konayashi @TBSten @nekomoti22