初期フローの合体をした #144
Merged
初期フローの合体をした #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tip デバッグビルドに成功しました |
|
Tip リリースビルドに成功しました |
TBSten
approved these changes
Feb 27, 2025
Comment on lines
+105
to
+114
| keyboardOptions = | ||
| KeyboardOptions.Default.copy( | ||
| imeAction = ImeAction.Done, | ||
| ), | ||
| keyboardActions = | ||
| KeyboardActions( | ||
| onDone = { | ||
| keyboardController?.hide() | ||
| }, | ||
| ), |
There was a problem hiding this comment.
[nits]
singleLine = true だけでやりたいことはできてそうなのでここは不要かも
Comment on lines
+133
to
+142
| keyboardOptions = | ||
| KeyboardOptions.Default.copy( | ||
| imeAction = ImeAction.Done, | ||
| ), | ||
| keyboardActions = | ||
| KeyboardActions( | ||
| onDone = { | ||
| keyboardController?.hide() | ||
| }, | ||
| ), |
There was a problem hiding this comment.
[nits]
ここも singleLine = true だけで良さそう
Comment on lines
+108
to
+115
| imeAction = ImeAction.Done, | ||
| ), | ||
| keyboardActions = | ||
| KeyboardActions( | ||
| onDone = { | ||
| keyboardController?.hide() | ||
| }, | ||
| ), |
There was a problem hiding this comment.
[nits]
ここも singleLine = true だけで良さそう
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やったこと
初期フローの合体
くまちゃんやユーザの名前等の入力をする際、改行できないようにした
テキストフィールドのカラーのコードで非推奨のコードを使用していたのを修正した
Close #82
やってないこと
空文字の例外処理
通知ダイアログの実装
スクリーンショット・動作確認
自己評価
出来を 10 点満点で自己評価:
8 点
その他