Dev bilayers#10
Open
TorecLuik wants to merge 8 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes across the Slurm workflow scripts, focusing on parameter type handling, error handling, and robustness. It also adds a new admin-only script for executing safe Slurm commands via OMERO. The most important changes are grouped below:
Parameter Type Handling and Workflow Descriptor Improvements:
convert_cytype_to_omtypewithconvert_param_type_to_omtypeand consistently reads the parameter type from thetypekey instead ofcytypein workflow parameter processing inSLURM_CellPose_Segmentation.py,SLURM_Run_Workflow.py, andSLURM_Run_Workflow_Batched.py. This improves compatibility with updated parameter schemas. [1] [2] [3]generic_descriptor_from_githubinstead ofpull_descriptor_from_github, and consistently accesses descriptor fields, improving maintainability and reducing ambiguity. [1] [2]Robustness and Error Handling:
run_workflowto verify that the job script exists on the Slurm cluster before submitting a workflow, providing a clear error if the script is missing.Bug Fixes:
_SLURM_Image_Transfer.pywhere splitting the target filename for zipping now correctly handles filenames with multiple periods by usingrsplit(".", 1).New Admin Script:
admin/Example_Minimal_Slurm_Script.py, a secure admin-only OMERO script for running selected Slurm or Linux commands on the cluster. It includes comprehensive safety checks to block dangerous commands, detailed logging, and user/admin validation to ensure only authorized actions are performed.