Refactor interactions #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myrkvi
force-pushed
the
chore/refactor-interactions
branch
from
2a59f72 to
f4f46e6
Compare
Adds a new interface InteractionMessager, and sets it as the first parameter in the helper methods for responding to interactions. This change is backwards compatible with the previous struct that was required, and is as such not a breaking change to those functions.
| if err != nil { | ||
| return discord.NewMessageCreateBuilder(). | ||
| SetEphemeral(true). | ||
| SetContent("Failed to retrieve infractions."), |
There was a problem hiding this comment.
Should use MessageEphWithContent
There was a problem hiding this comment.
No, this is in a function that returns the MessageCreate struct. It may contain embeds, in which returning a string with which to call MessageEphWithContent is not sufficient.
There was a problem hiding this comment.
Since you're just creating an ephemeral message and tacking on embeds, for consistency's sake you should either:
- Refactor MessageEphWithContent to send the builder.
- Create MessageBuilderEphWithContent and have MessageEphWithContent call it with .Build().
No preference as to which one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major refactoring regarding interactions / application commands
This PR puts previous commands and components in their own packages, under the infractions package. This results in interactions being more organised by their commands and related features, as well as moving registering to the interaction router within the package of each interaction package.
There has also been some light refactoring for code reuse, but also splitting up into multiple files, so that large commands such as the admin one has separate files for each sub-command, as it relates to configuration for various features.