-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ASPA support #132
Conversation
Thank you for the PR! This is getting very unwieldy and confusing. I wonder if it might be worth redesigning the whole thing – possibly also move it to rpki-rs so the code can be shared between RTRTR and Routinator. |
@partim you mean the json serialization part? I could leave those changes out of this PR and then someone could come by with a better impl that fits routinator and rtrtr. |
I think we can probably patch up the existing state machine for now – especially since you’ve kindly done all the hard work already – and then look into improving the code later. |
Should the CI be updated to use a later version? |
Yes, please – both the CI and I updated Routinator to 1.74 because of clap, so perhaps you can go that far here as well while we are at it. |
@partim is this ok to be merged now? |
Apologies for the delay! I had it on my list but then got caught up in other stuff. Looks great now. Thank you again for the PR! |
The new version of rpki-rs sets rtr max protocol version to 2, so we can do aspas here now. This provides aspa data in rtr and json. The rtr is very straightforward as it's all handled in rpki-rs. The json is complex due to the streaming model, but the state machine is maintained. Some tests are also included since it's difficult to reason about.