Nmf app 409 - feat: large header title #416
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k navigation and update associated options.
- Replace createStackNavigator with createNativeStackNavigator in AddEmissionNavigator. - Update navigation options for AddEmission, BarCodeScan, CategorySelection, and SubCategorySelection screens to use NativeStackNavigationOptions. - Enable large title and transparent header for CategorySelectionScreen on iOS. - Adjust InfoButton styles to remove unnecessary margin in native header.
Contributor
Author
|
@PierreBresson pushed a pr. If i missed any or we need different UX than what we have let me know will try addressing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ I have read the contributing file
Completes #409
Summary
This PR focuses on a major upgrade and standardization of the app's navigation system. The primary motivation was to migrate the codebase to React Navigation v7 and adopt
native-stackfor improved performance and native feel.Key changes include:
native-stack.Changelog
ANDROID_TAB_BAR_HEIGHTconstant from 60 to 90 to prevent content overlap on Android scroll views.@react-navigation/native-stack.navigationOptionsfor all feature and modal screens, removing redundant configs and adhering to platform defaults.getIOSVersionutility to resolve TypeScript errors.Note:
Saw this warning coming in when opening info modal from add emission screen We can cover it as a separate ticket