fix-the-autoannotate-metadata-workflow - #421
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…e_metadata git wf
Could you please explain this PR? Is it a PR for testing WF or it's a PR that we are going to merge in the end? Does it depend on the PR that is opened in the FAIRMD_lipids? Should we wait until we merge that one first? |
|
This PR was initially meant to find why the automatic metadata annotation workflow was failing. Now the wf itself is working. However it depends on NMRLipids/FAIRMD_lipids#506 to generate syntactically correct metadata files. The CAS_API_KEY is already injected for use with the python script. It does no harm as it is only used by the new version of autocomplete_metadata.py. |
comcon1
left a comment
comcon1
left a comment
There was a problem hiding this comment.
developer's script has been merged
| git clone --depth 1 https://github.com/NMRlipids/FAIRMD_lipids.git "$RUNNER_TEMP/Databank" | ||
| pip install "$RUNNER_TEMP/Databank" |
There was a problem hiding this comment.
Some non-blocking comments. You may think about it if you want. I don't have strong opinions here.
-
I think we could install latest stable version using
pip install fairmd.lipids. -
If we need a script from
develop, we could also checkout repo from stable tag -
I don't like very much that we are using out-of-package scripts in another repository; I think it's a bit wrong responsibility.. but I don't see an easy suggestion on how to improve it.
2 participants
No description provided.