Centralize tqdm handling and showing progress in CI - #455
Closed
jagdep-singh wants to merge 7 commits into
Closed
Conversation
Contributor
Author
|
@comcon1 i have no idea why these tests are not passing need help here |
Member
|
This is the proper fix of circular imports instead of what you did. I also fixed the style of optional arguments. You can force-push it to your branch. Then there are other tests which are broken currently. |
Member
|
You are growing your commit tree with merge intersection instead of just throwing away improper commits. Please check, how force-push works. You made a mistake commits, then you merged then you made other commits. It's not the way. Please stay on the commit before you made a mistake, then add commit, then force-push. Then you can consider merging. It's a proper sequence. |
comcon1
added a commit
that referenced
this pull request
Mar 1, 2026
* Centralize tqdm handling and showing progress in CI * Fix circular imports. Fix modern style of optional arguments. * Fix progress wrapping accepting no iterable pos arg * Use progress in new 4maicos non-gromacs centering interface * Linter fix * Fix test_uc, check that progress writes to stdout by default --------- Co-authored-by: jagdep-singh <jagdeep.singh12a@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR centralizes all progress-bar handling into a single
progress()helper and ensures progress is visible by default in all environments, including GitHub Actions.issue #431
Changes
progress()helper inlipids/_base.pyand re-exported it vialipids/__init__.pytqdmusages to use this helperWhy
Note
📚 Documentation preview 📚: https://databank--455.org.readthedocs.build/