Skip to content

Support sphingolipids naming convention - #475

Merged
comcon1 merged 5 commits into
NMRLipids:mainfrom
comcon1:support-sphingolipids-convention
Mar 11, 2026
Merged

Support sphingolipids naming convention#475
comcon1 merged 5 commits into
NMRLipids:mainfrom
comcon1:support-sphingolipids-convention

Conversation

@comcon1

@comcon1 comcon1 commented Mar 5, 2026

Copy link
Copy Markdown
Member

New naming convention developed with @tfmFerreira is now represented in the main repo.

  • tail retrurning function counts 'fa' and 'sphingosine' as tails
  • NMRPCA consider two-tailed sphingolipids egligible for the analysis
  • Documentation reflects the convention
  • Molecule list in the documentation is dynamically updated from the testing web portal
  • Pretty numerator supports new sphingolipids to number them properly

📚 Documentation preview 📚: https://databank--475.org.readthedocs.build/

@comcon1
comcon1 marked this pull request as ready for review March 5, 2026 10:56
@comcon1
comcon1 requested a review from MagnusSletten March 5, 2026 10:56
@comcon1

comcon1 commented Mar 5, 2026

Copy link
Copy Markdown
Member Author

@ohsOllila @markussmiettinen I want to draw your attention to the fact that the naming convention of sphingolipids has been changed during our meeting with @tfmFerreira. After this PR is approved and merged, if we find some of the lipids that don't align with this convention, the mapping files must be adopted, and not the code.

@mdondrup

Copy link
Copy Markdown
Collaborator

Hi, I think you should be able to approve this quickly. I have run an import check, and this branch is shown as the current state on the test server.

@mdondrup

Copy link
Copy Markdown
Collaborator

I just saw that I could review, so I approved. The changes seem sound. Ofc I don't know exactly what you @tfmFerreira and @comcon1 discussed.

@comcon1
comcon1 merged commit 1760430 into NMRLipids:main Mar 11, 2026
9 of 11 checks passed
@comcon1
comcon1 deleted the support-sphingolipids-convention branch May 24, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants