Support sphingolipids naming convention - #475
Merged
comcon1 merged 5 commits intoMar 11, 2026
Merged
Conversation
comcon1
marked this pull request as ready for review
March 5, 2026 10:56
Member
Author
|
@ohsOllila @markussmiettinen I want to draw your attention to the fact that the naming convention of sphingolipids has been changed during our meeting with @tfmFerreira. After this PR is approved and merged, if we find some of the lipids that don't align with this convention, the mapping files must be adopted, and not the code. |
Collaborator
|
Hi, I think you should be able to approve this quickly. I have run an import check, and this branch is shown as the current state on the test server. |
mdondrup
approved these changes
Mar 10, 2026
Collaborator
|
I just saw that I could review, so I approved. The changes seem sound. Ofc I don't know exactly what you @tfmFerreira and @comcon1 discussed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New naming convention developed with @tfmFerreira is now represented in the main repo.
📚 Documentation preview 📚: https://databank--475.org.readthedocs.build/