Skip to content

Stanza order fix #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andybeet merged 2 commits into from
Aug 27, 2025
Merged

Stanza order fix #164

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a82d0c9
in create.rpath.params, fixed unguaranteed assumption about ordering …
Aug 27, 2025
c9d242a
Merge branch 'dev' of github.com:NOAA-EDAB/Rpath into stanza_order_fix
Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion R/param.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,15 @@ create.rpath.params <- function(group, type, stgroup = NA) {
#Individual Stanza Parameters
ind.stanza.group <- model[!is.na(stgroup), Group]
ieco <- which(!is.na(stgroup))
# KYA Aug 2025 - The StGroupNum =rep() line below assumes that the
# each stanza grouping is "together" not interleaved - this is not
# guaranteed. The following lookup fixes that (data.frame used because
# data.table seems intractable to this).
stframe <- data.frame(stgroups)
row.names(stframe)<-stframe$StanzaGroup
gnum <- stframe[stgroup[!is.na(stgroup)],"StGroupNum"]
stindiv <- data.table(
StGroupNum = rep(stgroups[, StGroupNum], stgroups[, nstanzas]),
StGroupNum = gnum, #rep(stgroups[, StGroupNum], stgroups[, nstanzas]),
StanzaNum = as.integer(0),
GroupNum = ieco,
Group = ind.stanza.group,
Expand Down
Loading