Fix(#95): Pull vessel data from alternative source - #135
Merged
Conversation
Closed
stephanie-owen
previously approved these changes
Jun 25, 2026
stephanie-owen
left a comment
There was a problem hiding this comment.
Looks good!
Ran get_vessels and the output matched the other get_ functions: a list with the data table, sql statement, and colNames vector. No obvious issues glancing at the data table.
Checked documentation with pkgdown::build_site(). All necessary information was listed and spelling/formatting looked good.
Member
Author
|
The last commit was to address a failing |
BBeltz1
approved these changes
Jul 1, 2026
BBeltz1
left a comment
Contributor
There was a problem hiding this comment.
function performs as expected, output format is correct, documentation reads well, no obvious errors
stephanie-owen
approved these changes
Jul 1, 2026
stephanie-owen
left a comment
There was a problem hiding this comment.
Function runs and produces correct output. Documentation using pkgdown::build_site() looks good and contains all necessary information
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Justification
The
get_vessels()function didn't function correctly because of a special character in the underlying data. In addition the table it was pulling from was dated. The table now being pulled from is a valid/equivalent table.Fixes #95
Types of changes
What types of changes does this pull request introduce? Put an
xin the boxes that apply.This will inform the new release number.
Reviewer instructions
Assign at least 2 reviewers:
Please build the package from this branch, connect to the database, and then run the function
get_vessels(channel). A list of 2 items should be returned in the same format and the otherget_functions. Check the docs for readability/spelling by eitherpkgdown::build_site()or?get_vesselsFormatting
This repo contains an
air.tomlfile that automatically formats code to a set of standards.It is preferred that contributors and reviewers install the Air formatting tool.
Code submitted in this pull request will be automatically checked for correct formatting.