Skip to content

Fix(#95): Pull vessel data from alternative source - #135

Merged
andybeet merged 3 commits into
devfrom
fix/i95-get-vessels
Jul 8, 2026
Merged

Fix(#95): Pull vessel data from alternative source#135
andybeet merged 3 commits into
devfrom
fix/i95-get-vessels

Conversation

@andybeet

Copy link
Copy Markdown
Member

Justification

The get_vessels() function didn't function correctly because of a special character in the underlying data. In addition the table it was pulling from was dated. The table now being pulled from is a valid/equivalent table.

Fixes #95

Types of changes

What types of changes does this pull request introduce? Put an x in the boxes that apply.
This will inform the new release number.

  • Fix (non-breaking change which fixes a bug)
  • Feature (non-breaking change which adds or changes functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other change (if none of the other choices apply)

Reviewer instructions

Assign at least 2 reviewers:

  • one of which should be a maintainer of this repo,
  • the others should be familiar with the subject or problem.

Please build the package from this branch, connect to the database, and then run the function get_vessels(channel). A list of 2 items should be returned in the same format and the other get_ functions. Check the docs for readability/spelling by either pkgdown::build_site() or ?get_vessels

Formatting

This repo contains an air.toml file that automatically formats code to a set of standards.
It is preferred that contributors and reviewers install the Air formatting tool.
Code submitted in this pull request will be automatically checked for correct formatting.

@andybeet andybeet linked an issue Jun 24, 2026 that may be closed by this pull request
stephanie-owen
stephanie-owen previously approved these changes Jun 25, 2026

@stephanie-owen stephanie-owen left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Ran get_vessels and the output matched the other get_ functions: a list with the data table, sql statement, and colNames vector. No obvious issues glancing at the data table.

Checked documentation with pkgdown::build_site(). All necessary information was listed and spelling/formatting looked good.

@andybeet

andybeet commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

The last commit was to address a failing air workflow

@BBeltz1 BBeltz1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function performs as expected, output format is correct, documentation reads well, no obvious errors

@stephanie-owen stephanie-owen left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function runs and produces correct output. Documentation using pkgdown::build_site() looks good and contains all necessary information

@andybeet
andybeet merged commit 140f41b into dev Jul 8, 2026
10 checks passed
@andybeet
andybeet deleted the fix/i95-get-vessels branch July 8, 2026 14:35
@andybeet andybeet mentioned this pull request Jul 8, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get_vessel error

3 participants