Fix(#39): remove NAs before type casting - #138
Merged
Merged
Conversation
BBeltz1
approved these changes
Aug 7, 2026
BBeltz1
left a comment
Contributor
There was a problem hiding this comment.
code looks appropriate, coercion warning has been resolved on branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Justification
This issue was previously fixed but it appears the database has introduced additional data issues. Several STOCK_AREA values are either NAs or "NA". This warnings causes GitHub workflows to fail (although we could prevent workflows from failing on a warning, i'd prefere to fix the code). These NAs have been filtered out prior to type casting to numeric. Issue 39 was reopened.
Fixes #39
Types of changes
What types of changes does this pull request introduce? Put an
xin the boxes that apply.This will inform the new release number.
Reviewer instructions
Do the following on
devand this branch.channel <- dbutils::connect_to_database("server", "user")get_herring_data(channel)The coercion warning should be fixed
Formatting
This repo contains an
air.tomlfile that automatically formats code to a set of standards.It is preferred that contributors and reviewers install the Air formatting tool.
Code submitted in this pull request will be automatically checked for correct formatting.