Skip to content

Conversation

@SamuelTrahanNOAA
Copy link
Contributor

@SamuelTrahanNOAA SamuelTrahanNOAA commented Nov 12, 2025

This PR adds support for generating IFI products on Ursa.

  1. Remove IFI support on Hera from UPP. (Does not affect building IFI outside UPP.)
  2. Update libIFI.fd hash to one that knows about the IntelLLVM cmake compiler ID.
  3. Add modulefiles for linking with an external IFI library.
  4. Add modulefiles for testing IFI in the regression tests (netcdf-cxx4)
  5. Add regression tests for IFI. (Duplicate of Hera tests.)
  6. Use C compiler ID instead of Fortran to detect the compiler flag to enable C++ libraries in Fortran when using the strange ifort + icpx combination.

Dependent PR

The libIFI.fd updates must be merged first. You won't be able to view this PR unless you're logged in under a github account with access to the private repository.

@SamuelTrahanNOAA
Copy link
Contributor Author

@BenjaminBlake-NOAA - Conceivably, I could remove Hera support for IFI in this PR, as you requested. Should I do that in this PR?

@BenjaminBlake-NOAA
Copy link
Collaborator

@SamuelTrahanNOAA Yes, I think you can remove Hera support for IFI as part of this PR. Thanks

@SamuelTrahanNOAA
Copy link
Contributor Author

I've removed IFI support on Hera, but not all UPP Hera tests. Your issue requests that all UPP Hera support be removed. Non-IFI tests are outside the scope of this PR.

@BenjaminBlake-NOAA
Copy link
Collaborator

I've removed IFI support on Hera, but not all UPP Hera tests. Your issue requests that all UPP Hera support be removed. Non-IFI tests are outside the scope of this PR.

Yes that's fine, the removal of the other Hera tests can be handled in a separate PR.

@BenjaminBlake-NOAA
Copy link
Collaborator

@SamuelTrahanNOAA We will wait until the dependent IFI PR is merged before moving forward with processing this PR.

Earlier this year we actually replaced all of the fv3r regression tests in UPP with RRFS tests (see PR #1258 ). The fv3r tests are an older version of the RRFS test which use a smaller (CONUS) domain. So I think the ifi_standalone_fv3r test may not be needed and can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Draft

Development

Successfully merging this pull request may close these issues.

Port libIFI and UPP-IFI connection to Ursa

2 participants