ug_imp_nmb_acc: Those changes to the number accuracy of the implicit … #1147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…solver have been forgotten to merge by me. The solver conevergence computation have not been good before due to the choosen accuracies.
Collaborator
|
@aronroland thank you for submitting this PR! As soon as the testing information from ERDC is added we'll start the tests and review. |
Collaborator
|
Converting to draft. Please mark as ready to review when testing information is available. |
kestonsmith-noaa
pushed a commit
to kestonsmith-noaa/WW3
that referenced
this pull request
Jun 17, 2025
…allow-argument-mismatch' flag (NOAA-EMC#1147) * UFSWM - Fix type mismatch compiler error when gfortran 10 is used without '-fallow-argument-mismatch' flag. * FV3 - Fix type mismatch compiler error when gfortran 10 is used without '-fallow-argument-mismatch' flag. * ccpp-physics - Resolve various subroutine argument mismatches. * ccpp-framework - Add support to use mpi_f08 MPI module . * stochastic_physics - Fix type mismatch compiler error when gfortran 10 is used without '-fallow-argument-mismatch' flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put the number accuracy of the solver to real precision. This was done once and somehow it got lost.
Pull Request Summary
When using the combination of the number precision as it was in develop the solver did not converge to number accuracy, which it does now.
Description
If u run e.g. tp2.6 and the solver does not converge below 10E-12, now it does.
Please also include the following information:
bug
-->
Issue(s) addressed
none
Commit Message
Correcting number accuracy within the implicit ug solver.
Check list
Testing
tp2.6
needs to be discussed, anyway. From my point of view we need to add more tests in e.g. 2.6, it will be discussed.
No
Yes, if the implicit solver is of concern.
2 be continued.