Skip to content

Conversation

@mingchen-NOAA
Copy link
Collaborator

@mingchen-NOAA mingchen-NOAA commented Nov 21, 2025

Pull Request Summary

This addresses warnings during compilation for GFSv17.

Description

This PR merges in develop and fixes compilation warnings:

  • add only clause to use statement in w3wavemd and fix USE MODULE remarks #1520
  • fix Fortran compile flag scope to avoid ifx real-size override warning in WW3 and operational workflow #1522
  • replace EXTERNAL declarations with INTERFACE and CONTAINS for safer procedure referencing #1521
  • fix SCOTCH and MPI_COMM_RANK explicit-interface warnings for debug build #1531
  • fix MPI_WTIME interface warning in debug build using mpi_f08 #1530
  • and some bug fixes

Issue(s) addressed

No specifically but solves multiple for dev/ufs-weather-model branch

Commit Message

Merging a PR and develop to fix warnings during compilation

Check list

Testing

  • How were these changes tested?
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

Copy link
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While typically not required, to ensure we don't have unanticipated diffs with GFSv17, I also ran the WW3 regression tests. The diffs are:

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (17 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (17 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (6 files differ)
ww3_tp2.21/./work_b_metis                     (1 files differ)
ww3_tp2.3/./work_PR2_UQ                     (6 files differ)
ww3_tp2.3/./work_PR1                     (6 files differ)
ww3_tp2.3/./work_PR2_UQ_MPI                     (6 files differ)
ww3_tp2.3/./work_PR1_MPI                     (6 files differ)
ww3_tp2.3/./work_PR3_UQ                     (6 files differ)
ww3_tp2.3/./work_PR3_UQ_MPI                     (6 files differ)
ww3_tp2.3/./work_PR3_UNO                     (6 files differ)
ww3_tp2.3/./work_PR3_UNO_MPI                     (6 files differ)
ww3_tp2.3/./work_PR2_UNO_MPI                     (6 files differ)
ww3_tp2.3/./work_PR2_UNO                     (6 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.1/./work_unstr_b                     (808 files differ)
ww3_ufs1.1/./work_unstr_a                     (797 files differ)
ww3_ufs1.1/./work_unstr_d                     (directory not found)
ww3_ufs1.1/./work_unstr_c                     (807 files differ)
ww3_ufs1.3/./work_a                     (3 files differ)

Note the tp2.3 diffs are from #1517
and the ufs1.1 are from #1507
There are no "answer" changes for what will be run in GFSv17, however we do have fixes for compiler warnings.

Additionally updates for using implicit scheme (if chosen) are added. These are currently not used but now would be available in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants