Skip to content

[dev/gfs.v17] Bring in updated MOM6 logging feature#4688

Draft
dpsarmie wants to merge 1 commit intoNOAA-EMC:dev/gfs.v17from
dpsarmie:v17/mom6_logging
Draft

[dev/gfs.v17] Bring in updated MOM6 logging feature#4688
dpsarmie wants to merge 1 commit intoNOAA-EMC:dev/gfs.v17from
dpsarmie:v17/mom6_logging

Conversation

@dpsarmie
Copy link
Contributor

Description

This PR will bring in MOM6 logging changes that are in the UFSWM develop branch to the GFSv17 branch in Global Workflow.

This PR will change the MOM6 output filenames by adding a _00 string to the name. This was a feature that was originally needed by the SFS project and now requested by GFS.

This update is related to #4249 , which is the original request from SFS.

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this change expected to change outputs (e.g. value changes to existing outputs, new files stored in COM, files removed from COM, filename changes, additions/subtractions to archives)? YES/NO (If YES, please indicate to which system(s))
    • GFS
    • GEFS
    • SFS
    • GCAFS
  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? YES
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model -- No pending PR until tests are done via GW
    • wxflow

How has this been tested?

These changes were tested just using the UFSWM regression tests. The WM itself passed testing, however this will still need to be tested in the GW.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@dpsarmie
Copy link
Contributor Author

This will remain a draft until these changes are tested in GW and with GDASApp (due to changes in the MOM6 CMake file).
Once the tests are complete and passing, the UFSWM branch from my fork will be merged into the UFSWM production/GFS.v17 branch, the hashes in this PR will be updated, and this PR will be marked ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant