Skip to content

Source set_strict rather than call it as a function#4690

Draft
CoryMartin-NOAA wants to merge 5 commits intoNOAA-EMC:developfrom
CoryMartin-NOAA:feature/strict
Draft

Source set_strict rather than call it as a function#4690
CoryMartin-NOAA wants to merge 5 commits intoNOAA-EMC:developfrom
CoryMartin-NOAA:feature/strict

Conversation

@CoryMartin-NOAA
Copy link
Contributor

Description

To adhere to NWS operational standards, we must, rather than define and execute bash functions to set and unset strict mode, source ush scripts that set and unset strict mode. This PR removes the functions and instead creates simplified bash that can be sourced, and all places that previously called the functions have been replaced by a source of the scripts.

Additionally, the set_strict has been removed from jjob_shell_setup and is now explicitly called at the top of every j-job.

Resolves ##4682

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this change expected to change outputs (e.g. value changes to existing outputs, new files stored in COM, files removed from COM, filename changes, additions/subtractions to archives)? NO
  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? Maybe?
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow

How has this been tested?

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@CoryMartin-NOAA CoryMartin-NOAA self-assigned this Mar 20, 2026
@CoryMartin-NOAA
Copy link
Contributor Author

CoryMartin-NOAA commented Mar 20, 2026

@RussTreadon-NOAA @DavidNew-NOAA I have a hunch this will require changes to GDASApp tests. Let me check and if so, I will open a PR there too.

EDIT: A grep/search says we should (hopefully) be good

@CoryMartin-NOAA
Copy link
Contributor Author

Running -G and -C tests on Ursa. Will report back once they are done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant