Source set_strict rather than call it as a function#4690
Draft
CoryMartin-NOAA wants to merge 5 commits intoNOAA-EMC:developfrom
Draft
Source set_strict rather than call it as a function#4690CoryMartin-NOAA wants to merge 5 commits intoNOAA-EMC:developfrom
CoryMartin-NOAA wants to merge 5 commits intoNOAA-EMC:developfrom
Conversation
Contributor
Author
|
@RussTreadon-NOAA @DavidNew-NOAA I have a hunch this will require changes to GDASApp tests. Let me check and if so, I will open a PR there too. EDIT: A grep/search says we should (hopefully) be good |
Contributor
Author
|
Running -G and -C tests on Ursa. Will report back once they are done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To adhere to NWS operational standards, we must, rather than define and execute bash functions to set and unset strict mode, source
ushscripts that set and unset strict mode. This PR removes the functions and instead creates simplified bash that can be sourced, and all places that previously called the functions have been replaced by a source of the scripts.Additionally, the set_strict has been removed from jjob_shell_setup and is now explicitly called at the top of every j-job.
Resolves ##4682
Type of change
Change characteristics
How has this been tested?
Checklist