Update eobs ATMGES variable in JJOB for develop#4691
Merged
DavidHuber-NOAA merged 3 commits intoNOAA-EMC:developfrom Mar 20, 2026
Merged
Update eobs ATMGES variable in JJOB for develop#4691DavidHuber-NOAA merged 3 commits intoNOAA-EMC:developfrom
DavidHuber-NOAA merged 3 commits intoNOAA-EMC:developfrom
Conversation
Contributor
Author
|
Gaea-C6 Tests - All Pass |
Contributor
Author
|
WCOSS2 Tests |
Contributor
Author
|
Failed WCOSS2 Tests C96_atm3DVar_extended_dev_eobs3 C48_S2SW_extended_dev_eobs3 This errors do not seem to be related to this PR. Opening for review. |
CatherineThomas-NOAA
requested review from
DavidHuber-NOAA and
TravisElless-NOAA
as code owners
TravisElless-NOAA
approved these changes
Mar 20, 2026
DavidHuber-NOAA
approved these changes
Mar 20, 2026
Contributor
|
Merging. Also, I happen to be running a baseline test on WCOSS2 from develop. If there are errors in the gempakmeta jobs, I'll open a follow-up issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@lgannoaa discovered a silent failure in the v17 real time in the eobs JJOB JGLOBAL_ENKF_SELECT_OBS:
The variable ATMGES is not defined in this JJOB. This PR replaces this variable with ATMGES_ENSMEAN, eliminating the error and properly defining LEVS.
This PR brings this fix into develop branch. A separate PR was opened to bring this fix into
dev/gfs.v17#4663Resolves #4615
Type of change
Change characteristics
How has this been tested?
generate_workflow -G -E -S -C on Gaea C6 and WCOSS2, all Gaea tests passed (will post below), WCOSS2 passed except for gempak jobs that seem unrelated to this PR. Compared results with develop on WCOSS2 for lowres v17 tests and results were identical. Testing done at 28f907f
Checklist