Skip to content

Feature/mynn sfc submodule#1052

Merged
DusanJovic-NOAA merged 10 commits intoNOAA-EMC:developfrom
XiaSun-Atmos:feature/mynn_sfc_submodule
Feb 17, 2026
Merged

Feature/mynn sfc submodule#1052
DusanJovic-NOAA merged 10 commits intoNOAA-EMC:developfrom
XiaSun-Atmos:feature/mynn_sfc_submodule

Conversation

@XiaSun-Atmos
Copy link
Copy Markdown
Contributor

Description

Added feature: MYNN surface layer scheme submodule
No change of answers are expected from this PR

Issue(s) addressed

  • fixes #<issue_number>

Testing

Full rt test is running now on Ursa
The code updates change will not change regression test baseline.

Dependencies

@XiaSun-Atmos XiaSun-Atmos marked this pull request as ready for review February 5, 2026 18:06
@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

Could we get approvals on this PR in order to process WM PR 3052?

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

gspetro-NOAA commented Feb 13, 2026

@grantfirl We're about ready to start processing WM PR 3052. Could we get your approval here on the UFSATM sub-PR?

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

Testing for ufs-community/ufs-weather-model#3052 has completed successfully. However, we need another approval on this PR before we can move forward. (Also waiting for CCPP merge, which should be imminent.)

@grantfirl
Copy link
Copy Markdown
Collaborator

@gspetro-NOAA @XiaSun-Atmos ufs-community/ccpp-physics#345 has been merged.

Copy link
Copy Markdown
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a CCPP point of view.

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

@XiaSun-Atmos Please revert .gitmodules and update the ccpp-physics hash to fa51a56.

@XiaSun-Atmos
Copy link
Copy Markdown
Contributor Author

XiaSun-Atmos commented Feb 17, 2026

@XiaSun-Atmos Please revert .gitmodules and update the ccpp-physics hash to fa51a56.

@gspetro-NOAA @grantfirl Dones. Please let me know if anything else needs to be changed. Thanks.

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

This PR can be merged.

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

@DusanJovic-NOAA Could you please merge this PR?

@DusanJovic-NOAA DusanJovic-NOAA merged commit 8cb8c31 into NOAA-EMC:develop Feb 17, 2026
8 checks passed
@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

The title/description is lacking a bit. Could someone please change the title to better match what this PR does and describe in detail?

Something as simple as:

Converts mynnsfc_wrapper to module_sf_mynnsfc_driver where applicable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants