Skip to content

Updates for USAF 557WW and NESDIS - #393

Merged
AlysonStahl-NOAA merged 8 commits into
NOAA-EMC:developfrom
emkemp:fix/557ww_updates
Nov 6, 2025
Merged

Updates for USAF 557WW and NESDIS#393
AlysonStahl-NOAA merged 8 commits into
NOAA-EMC:developfrom
emkemp:fix/557ww_updates

Conversation

@emkemp

@emkemp emkemp commented May 28, 2025

Copy link
Copy Markdown
Contributor

This pull request includes changes to support select variables from the USAF 557WW GRIB2 Reference Table. The main focus is on variables produced by the Global Hydro-Information (GHI) system, an implementation of the NASA Land Information System.

There are also a handful of updates provided by NOAA/NESDIS, which were incorporated into the NASA fork of wgrib2.

@webisu

webisu commented May 29, 2025 via email

Copy link
Copy Markdown
Collaborator

@emkemp

emkemp commented May 29, 2025

Copy link
Copy Markdown
Contributor Author

Thank you for replying so promptly.

I will reach back to the USAF for the latest edition of their GRIB Edition 2 Reference Manual.

@emkemp

emkemp commented May 29, 2025

Copy link
Copy Markdown
Contributor Author

I have a copy of the GRIB manual from 557WW, dating from 2023. It is a Word document. Do you have an email address that I can send it to?

@webisu

webisu commented May 30, 2025 via email

Copy link
Copy Markdown
Collaborator

@webisu

webisu commented Jun 2, 2025

Copy link
Copy Markdown
Collaborator

The main worry that I have are the names for the grib variables. Names are not part of the grib2 standard but should have some official status. Later on someone could define "official" names for the 557WW or Nesdis gribtables. There is an "extra" directories for user contributions which seems like a possible place for a non-official grib table. The other tables are descriptive can remain in the main source code directory. Anyways this is my opinion and others are welcome.

@manfredsc

Copy link
Copy Markdown
Contributor

@emkemp, the files CodeTable_3.2.dat and CodeTable_4.212.dat are generated from scripts in the wmo_scripts directory.
It would be great if this could stay as-is. So either modify the scripts directly (there are examples of how to add custom
entries in some scripts), or introduce your own CodeTable versions which are conditionally included.

And do not add else string="undefined" clauses, string == NULL is catched in code.

I'm most probably blind, but where are all the files CodeTable_*.USAF.dat used in the code? I only see CodeTable_4.235.USAF.dat
being included in CodeTable.c, the rest I did not find.

It is very unfortunate that USAF redefines official WMO entries, but I guess there's not much you can do about it :-(

@emkemp

emkemp commented Jun 10, 2025

Copy link
Copy Markdown
Contributor Author

Catching up to this:

@manfredsc I don' t understand your comment about USAF redefining official WMO entries. All variables (parameters) specified in the official WMO documentation are supported. They only specify parameters that are reserved for local use.

There is only one standalone USAF table added. The rest of the changes were (apparently unsatisfactorily) added to existing .dat files. I will work on incorporating your suggestions.

@emkemp

emkemp commented Jun 10, 2025

Copy link
Copy Markdown
Contributor Author

I just pushed some changes, moving the USAF specific files into the same directory, and split CodeTables 3.2 and 4.235 into separate tables.

Regarding removal of the "string="undefined"" code -- those changes are included in the latest push. However, I note that your own wmo_scripts/get_code_Table_4.3.sh needs to be updated to make the same change.

@manfredsc

Copy link
Copy Markdown
Contributor

@emkemp, well, I stand corrected.
First, I was thinking of table 4.235, but this is no WMO table, it only exists at http://www.nco.ncep.noaa.gov/pmb/docs/grib2/grib2_doc
Second, for your changes of tables 1.3 and 1.4, the real issue is that they are badly outdated
and really should be generated from current WMO documentation. Then your changes would no longer be needed.
This is an oversight, I will look into it.

@emkemp

emkemp commented Jul 16, 2025

Copy link
Copy Markdown
Contributor Author

This is a follow-up on the question of "official status" on the GRIB2 abbreviations I added to wgrib2.

I provided a list of the abbreviations to Mr Nate Wright, Deputy Chief of Environmental Information for the 16th Weather Squadron. His response:

"""
Eric,

I’ve finally gotten around to taking a look at these. I have no problems with any of these so you have my endorsement to proceed.

Thanks!
"""

I can add you to the email chain if you want more thorough confirmation, or wish to engage Mr Wright directly. (I will not be offended!) Please let me know how you want to proceed.

@AlysonStahl-NOAA
AlysonStahl-NOAA self-requested a review November 4, 2025 22:33
@AlysonStahl-NOAA
AlysonStahl-NOAA merged commit 98d1f71 into NOAA-EMC:develop Nov 6, 2025
41 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants