Skip to content

Use g2c for AEC packing/unpacking - #460

Merged
AlysonStahl-NOAA merged 22 commits into
NOAA-EMC:developfrom
AlysonStahl-NOAA:as_aec
Nov 6, 2025
Merged

Use g2c for AEC packing/unpacking#460
AlysonStahl-NOAA merged 22 commits into
NOAA-EMC:developfrom
AlysonStahl-NOAA:as_aec

Conversation

@AlysonStahl-NOAA

@AlysonStahl-NOAA AlysonStahl-NOAA commented Oct 16, 2025

Copy link
Copy Markdown
Collaborator

Fixes #461

This won't work until the next release of g2c where these interfaces are included.

@AlysonStahl-NOAA
AlysonStahl-NOAA marked this pull request as ready for review November 5, 2025 21:12

@Hang-Lei-NOAA Hang-Lei-NOAA left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code should work fine. But should the workflow first check if AEC lib is available?

@AlysonStahl-NOAA
AlysonStahl-NOAA merged commit 6e50955 into NOAA-EMC:develop Nov 6, 2025
20 checks passed
@AlysonStahl-NOAA
AlysonStahl-NOAA deleted the as_aec branch November 6, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace AEC packing/unpacking with g2c routines

2 participants