test_diag_integral: Avoid I/O unit 100 #1605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Cray compiler reserves I/O unit 100 for STDIN, which causes `read_diag_integral_file` to fail. This is fixed by using `newunit` instead of specifying `unit=100`.
J-Lentz
requested review from
bensonr,
rem1776 and
uramirez8707
as code owners
uramirez8707
approved these changes
Oct 23, 2024
laurenchilutti
approved these changes
Oct 24, 2024
rem1776
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Cray compiler reserves I/O unit 100 for STDIN, which causes
read_diag_integral_fileto fail. This is fixed by usingnewunitinstead of specifyingunit=100.How Has This Been Tested?
diag_integral test builds, runs, and passes with CCE 18 on C5.
Checklist:
make distcheckpasses