MODERN_DIAG_MANAGER: Improvements to the diag_table.yaml format #1731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… prepare for the addition of anchor support in the parser
… code more robust and avoid out of bounds issues
uramirez8707
requested review from
bensonr,
rem1776 and
vithikashah001
as code owners
bensonr
reviewed
Aug 18, 2025
parser/yaml_parser.F90
Outdated
Comment on lines
287
to
289
| case (MAX_LEVELS_REACH) | ||
| call mpp_error(FATAL, "The file:"//trim(filename)//" has reached the maximum number of level!"//& | ||
| "Try setting -DMAX_LEVELS to a number greater than the current limit.") |
There was a problem hiding this comment.
Defining the macro requires a recompile and the message should say that. Is there a way to make MAX_LEVELS a runtime option?
There was a problem hiding this comment.
Thanks, I’ve updated the error message.
Yes, making MAX_LEVELS a runtime option would be cleaner.
I didn’t pursue it yet since none of our current YAMLs come close to that limit, but I've open an issue to work on that in a future release: #1755
vithikashah001
approved these changes
Aug 21, 2025
rem1776
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor the fms_yaml_parser code to enhance readability, maintainability, and in-code documentation
Adds support for yaml anchors in fms_yaml_parser (Fixes #1677)
Adds code to allow grouping variables by module in the diag yaml (Fixes #1678)
How Has This Been Tested?
CI including new tests!
Checklist:
make distcheckpasses