- 
                Notifications
    You must be signed in to change notification settings 
- Fork 155
add nvhpc compiler flags to cmake #1743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| mosaic2/include | ||
| constants | ||
| astronomy/include | ||
| field_manager/ | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When building with nvhpc it could not find parse.inc which is here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting in these changes! I have some other cmake changes (#1694 ) that will be going in soon so this might need an update after that is merged but based on what im seeing it shouldn't be anything major.
Co-authored-by: Ryan Mulhall <[email protected]>
Co-authored-by: Ryan Mulhall <[email protected]>
| We should push up the minimum cmake version - before cmake 3.20 there is no NVHPC compiler it goes back to the PGI one for which no flags are defined. Is there a reason to keep the cmake version minimum at 3.12? | 
| only these tests fail (with nvhpc 24.9)  | 
| 
 No I don't think so, feel free to bump it up if needed. | 
Description
Add the necessary flags to compile FMS with NVHPC using the CMake build system
Fixes # (issue)
How Has This Been Tested?
CMake does not have the unit tests connected to the build system but building using the autoconf mode with NVHPC fails most of the tests. Which I believe is known.
Checklist:
make distcheckpasses