Correct the use iau_offset and add new functions to output restart files#176
Correct the use iau_offset and add new functions to output restart files#176MingjingTong-NOAA wants to merge 2 commits intoNOAA-GFDL:mainfrom
Conversation
step restart files and the function to control the starting time to output restart files.
|
@JosephMouallem and @laurenchilutti, I couldn't assign the reviewers of this PR from the github page. This PR is one of the four PRs for shield DA related changes. Other three PRs are listed below NOAA-GFDL/SHiELD_physics#81 The above failing check can be resolved by including the changes in NOAA-GFDL/atmos_drivers#70 The test case and scripts can be found in this google doc: https://docs.google.com/document/d/1gWwZoDWtxfpDuKmH99oeBUzgGe_pmdGZb8N1P8fxy_0/edit?tab=t.0 Thank you for reviewing the code. |
| endif | ||
|
|
||
| call fms_mpp_clock_begin(coupler_clocks%atmos_model_init) | ||
| Atm%iau_offset = iau_offset |
There was a problem hiding this comment.
This is causing the CI testing to fail on this PR with the compilation error: "Error: 'iau_offset' at (1) is not a member of the 'atmos_data_type' structure"
|
It is important for this PR to be reviewed for compatibility with other GFDL models. The PRs in FMS Coupler are now going to be reviewed by the fmscoupler task force. The email for this group is: oar.gfdl.fmscoupler-task-force@noaa.gov. We should schedule a meeting to present these changes and seek their input. |
|
@MingjingTong-NOAA: While all models now run with the full coupler, unlike SHiELD, the other models use a different atmosphere driver The failed check occurs because the tests here run under this configuration |
|
Is it possible to put these modifications into |
|
Hi All, Thank you so much for reviewing the PRs. I'll address all your comments in the coming couple of days. |
|
I've moved the iau_offset related changes into atmos_drivers/SHiELD/atmos_model.F90 |
|
As per our last discussion, the changes here will be moved to the atmosphere driver level, so no changes will be made here, thanks. |
5 participants
This PR is part of the changes made to enable DA cycling functions. In particular, the use of iau_offset variable has been corrected and new functions to control the output of restart files has been added, which allows the output of the restart file at the first time step through the control parameter restart_first_time_step and a new parameter restart_start is used to specify the starting time to output the restart file.
A forecast test was run to compare with the main branch and the results are bit-wise identical.