Brine plume changes, passing info from SIS2 to MOM6#177
Open
breichl wants to merge 1 commit intoNOAA-GFDL:mainfrom
Open
Brine plume changes, passing info from SIS2 to MOM6#177breichl wants to merge 1 commit intoNOAA-GFDL:mainfrom
breichl wants to merge 1 commit intoNOAA-GFDL:mainfrom
Conversation
breichl
commented
Apr 16, 2026
- Adds necessary code in the FMS coupler to allocate the ice_ocean_boundary field "excess_salt". This is needed to use the brine plume parameterization that relies on an additional information exchange between SIS2 and MOM6.
- Adds necessary code in the FMS coupler to pass the salt_left_behind from SIS2 to the ice_ocean_boundary excess_salt field, making it available for use in MOM6.
Author
|
I assume the test is probably failing because it uses a version of MOM6 prior to the addition of excess_salt to the ice_ocean_boundary type. I have tested this with the dev/gfdl versions of MOM6 and SIS2 and confirmed it works in ice_ocean mode. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.