*Update ocean_only/SCM_idealized_hurricane test case #485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the ocean_only/SCM_idealized_hurricane test case to set its wind stresses via idealized_hurricane_wind_forcing(), rather than the soon-to-obsoleted routine SCM_idealized_hurricane_wind_forcing(). The two are mathematically equivalent, but the former is more flexibly configurable (it is also used in the ocean_only/idealized_hurricane test case) and satisfies dimensional consistency testing. This change is done by setting WIND_CONFIG = "ideal_hurr" and IDL_HURR_X0 = 6.48e5, which give results that differ at roundoff from the previous settings. The regression answers will have to be updated. The MOM_parameter_doc files have been updated to reflect this change. Once this update to this test case is in place, the value of "SCM_ideal_hurr" for WIND_CONFIG will be obsoleted and the SCM_idealized_hurricane_wind_forcing() routine can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the ocean_only/SCM_idealized_hurricane test case to set its wind stresses via
idealized_hurricane_wind_forcing(), rather than the soon-to-obsoleted routineSCM_idealized_hurricane_wind_forcing(). The two configurations are mathematically equivalent, but the former routine is more flexibly configurable (it is also used in the ocean_only/idealized_hurricane test case) and satisfies dimensional consistency testing. This change is done by settingWIND_CONFIG = "ideal_hurr"andIDL_HURR_X0 = 6.48e5, which give results that differ at roundoff from the previous settings. The regression answers will have to be updated. The MOM_parameter_doc files have been updated to reflect this change.Once this update to this test case is in place, the value of "SCM_ideal_hurr" for
WIND_CONFIGwill be obsoleted and theSCM_idealized_hurricane_wind_forcing()routine can be removed.