Skip to content

Adding OM5 Baltic test cases #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

Adding OM5 Baltic test cases #522

merged 1 commit into from
Apr 15, 2025

Conversation

@breichl
Copy link
Contributor

@breichl breichl commented Apr 11, 2025

  • Adds two test cases, one Baltic grid with OM5 settings, and second with OM5 non-Boussinesq settings.
  • These test cases can be used to test several OM5 settings that are not exercised in the current MOM6 test suite.
  • The examples use the OM4 Baltic test case and forcing for simplicity.

Adding OM5 Baltic test cases
8a09182 
- Adds two test cases, one Baltic grid with OM5 settings, and second with OM5 non-Boussinesq settings.
- These test cases can be used to test several OM5 settings that are not exercised in the current MOM6 test suite.
- The examples use the OM4 Baltic test case and forcing for simplicity.
@breichl
Copy link
Contributor Author

breichl commented Apr 11, 2025

@jkrasting FYI

@breichl breichl requested a review from Hallberg-NOAA April 11, 2025 18:11
@aekiss aekiss mentioned this pull request Apr 14, 2025
Open
Hallberg-NOAA
Hallberg-NOAA approved these changes Apr 15, 2025
View reviewed changes
Copy link
Member

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have examined these files, and these new experiments seem to me to be correct.

@Hallberg-NOAA Hallberg-NOAA merged commit 132c01f into NOAA-GFDL:dev/gfdl Apr 15, 2025
2 checks passed
@Hallberg-NOAA
Copy link
Member

This PR was reverted because it was missing the .datasets pointers in the INPUT directories. As presently written, it was failing and breaking all of the MOM6 testing of subsequent PRs. @breichl, please add the INPUT/.datasets pointers and then add this PR again.

Sorry for the confusion and extra hassle with this PR.

@breichl
Copy link
Contributor Author

breichl commented Apr 16, 2025

This PR was reverted because it was missing the .datasets pointers in the INPUT directories. As presently written, it was failing and breaking all of the MOM6 testing of subsequent PRs. @breichl, please add the INPUT/.datasets pointers and then add this PR again.

Sorry for the confusion and extra hassle with this PR.

Got it, my fault. The .gitignore was set to ignore these files and I missed the '-f' flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hallberg-NOAA Hallberg-NOAA Hallberg-NOAA approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@breichl @Hallberg-NOAA