Skip to content

Conversation

@marshallward
Copy link
Member

MRS restart testing is modified to only append DAYMAX to MOM_input if the test does not use input.nml. If the input uses input.nml to set runtime, then DAYMAX is not used.

This prevents errors for runs using FATAL_UNUSED_PARAMS.

MRS restart testing is modified to only append DAYMAX to MOM_input if
the test does not use input.nml.  If the input uses input.nml to set
runtime, then DAYMAX is not used.

This prevents errors for runs using FATAL_UNUSED_PARAMS.
Copy link
Member

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes all seem to be correct to me, and should address some of the issues we have been having with unread parameters for some cases.

@Hallberg-NOAA Hallberg-NOAA merged commit fe59e55 into NOAA-GFDL:dev/gfdl Apr 18, 2025
2 checks passed
@marshallward
Copy link
Member Author

I goofed this up badly:

  • 02.ignore was modifying DAYMAX right after the if-block
  • 01.ignore was not using HALF_DAYMAX.

Here is the revised commit. 76f7016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants