Fix premature FMS lib tests in coupled models #531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FMS infra test was incorrectly set before the Fortran compiler is declared, and before any FMS library tests. This caused the test to run with a C compiler, and before the library had even been verified to exist. The ice-ocean model ran this macro before and after the FMS testing. It seems to have covered up the incorrect macro. The AM2-coupled model only ran this macro before Fortran and FMS setup. It never correctly tested its FMS infra, and errors could follow. This patch cleans up the tests so that each model runs the macro after FMS macro testing.
adcroft
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FMS infra test was incorrectly set before the Fortran compiler is declared, and before any FMS library tests. This caused the test to run with a C compiler, and before the library had even been verified to exist.
The ice-ocean model ran this macro before and after the FMS testing. It seems to have covered up the incorrect macro.
The AM2-coupled model only ran this macro before Fortran and FMS setup. It never correctly tested its FMS infra, and errors could follow.
This patch cleans up the tests so that each model runs the macro after FMS macro testing.