Fix re-compilation on dependency changes in Makefiles #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced ${ } with $( ) in ice_ocean_SIS2/Makefile (typo)
- Moved $(BUILD)/$(TARGET): recipe upward out of config/Libs.mk to allow
dependency state detection. For some reason we cannot find documentation
on, the dependencies resulting from a macro (function) were not evaluated
when inside an included file. :(
Todo:
- Have icebergs/Makefile detect which FMS is being used
- List sub-directories full/ and shared/ within coupler/. Newer versions of the
coupler have multiple versions of some files which causes conflicts for
makedep.
marshallward
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo: