Merged
Conversation
…iles for NetCDF, misspelled before
7 tasks
mlee03
reviewed
Mar 23, 2026
Contributor
mlee03
left a comment
mlee03
left a comment
There was a problem hiding this comment.
Thinking about a future where a build change needs to be made, I think I prefer to have one main CMakeLists.txt that needs to be changed instead of having one for each module. But I'm no expert and I will go with what you guys decide :)
mlee03
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a method for installing
cFMSthroughCMake. This will enable changes withinpyFMSto move away from the current install method, which relies on interrupting thebuildmethod ofsetuptoolsto run a shell script to installFMSandcFMS. A subsequent PR inpyFMSwill change the build backend of the package toscikit-build-core, which allows forCMakebased installations of extension modules for Python packages.As is seen in the
CMakeLists.txt,FMScan either be installed via a call toFetchContentoradd_subdirectorymethods ofCMake. If the former is used,FMSwould no longer be required as a submodule tocFMS, as it would be installed directly from its GitHub repository. The latter method was chosen for this PR given the current structure of thecFMSrepository.This PR should be reviewed after the merge of PR 1850 in FMS, which will prevent the automatic building of the FMS unit tests.