Skip to content

Rename src dir instead of removing#848

Open
singhd789 wants to merge 24 commits intoNOAA-GFDL:mainfrom
singhd789:844.force-checkout-rename
Open

Rename src dir instead of removing#848
singhd789 wants to merge 24 commits intoNOAA-GFDL:mainfrom
singhd789:844.force-checkout-rename

Conversation

@singhd789
Copy link
Copy Markdown
Contributor

@singhd789 singhd789 commented Apr 8, 2026

Describe your changes

Previously, the --force-checkout option removed the checkout script and src_dir that was already generated and re-created them. This did not mimic the current --force-checkout behavior in Bronx (which is also a bit more safe). If --force-checkout is used, the src_dir is renamed (in the same location) to src.[timestamp].

This was only done for bare-metal builds. THe container build doesn't need this as the src code is INSIDE the container.

  • also changed os bits to Path

Issue ticket number and link (if applicable)

Fixes #844

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback
  • No print statements; all user-facing info uses logging module

Note: If you are a code maintainer updating the tag or releasing a new fre-cli version, please use the release_procedure.md template. To quickly use this template, open a new pull request, choose your branch, and add ?template=release_procedure.md to the end of the url.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.34%. Comparing base (dea2038) to head (52dd89c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #848      +/-   ##
==========================================
+ Coverage   84.14%   84.34%   +0.20%     
==========================================
  Files          71       71              
  Lines        4975     4996      +21     
==========================================
+ Hits         4186     4214      +28     
+ Misses        789      782       -7     
Flag Coverage Δ
unittests 84.34% <100.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
fre/make/create_checkout_script.py 97.46% <100.00%> (+9.96%) ⬆️
fre/make/create_docker_script.py 100.00% <100.00%> (ø)
fre/make/run_fremake_script.py 97.95% <100.00%> (+0.81%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dea2038...52dd89c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread fre/make/create_checkout_script.py Outdated
Comment thread fre/make/tests/test_create_checkout.py Outdated
@singhd789 singhd789 requested a review from mlee03 April 15, 2026 18:18
@singhd789 singhd789 assigned ilaflott and unassigned ilaflott Apr 16, 2026
@singhd789 singhd789 requested a review from ilaflott April 16, 2026 15:18
@singhd789 singhd789 requested review from ceblanton and ilaflott April 16, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename src/ directory in fre make checkout --force-checkout (instead of removing)

5 participants