Update logic where postprocess_on and analysis_on is used#861
Update logic where postprocess_on and analysis_on is used#861singhd789 merged 19 commits intoNOAA-GFDL:mainfrom
postprocess_on and analysis_on is used#861Conversation
- `postprocess_on` is True by default if not explicitly set in the pp yaml - optional key
|
Validation error related to this PR: NOAA-GFDL/gfdl_msd_schemas#50 |
postprocess_on and analysis_on is used
|
Note: I thiiiiiink these are all the places |
ceblanton
left a comment
There was a problem hiding this comment.
I can't believe we're doing so many relatively drastic changes.. this and the name changes together. We sure are bold!
This looks great and I think would pass also except for the case where the analysis yaml has no items.
…to 847.pp-an-switch-default
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #861 +/- ##
=======================================
Coverage 84.14% 84.14%
=======================================
Files 71 71
Lines 4975 4975
=======================================
Hits 4186 4186
Misses 789 789
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Describe your changes
postprocess_onandanalysis_onare True by default if not explicitly set in the pp yaml (made an optional key)listtools.rst,pp_yaml.rstIssue ticket number and link (if applicable)
postprocess_onandanalysis_on#847postprocess_on: Truethe default in the workflow fre-workflows#228Checklist before requesting a review
Note: If you are a code maintainer updating the tag or releasing a new fre-cli version, please use the
release_procedure.mdtemplate. To quickly use this template, open a new pull request, choose your branch, and add?template=release_procedure.mdto the end of the url.