Skip to content

Update logic where postprocess_on and analysis_on is used#861

Merged
singhd789 merged 19 commits intoNOAA-GFDL:mainfrom
singhd789:847.pp-an-switch-default
Apr 16, 2026
Merged

Update logic where postprocess_on and analysis_on is used#861
singhd789 merged 19 commits intoNOAA-GFDL:mainfrom
singhd789:847.pp-an-switch-default

Conversation

@singhd789
Copy link
Copy Markdown
Contributor

@singhd789 singhd789 commented Apr 13, 2026

Describe your changes

  • Ensures postprocess_on and analysis_on are True by default if not explicitly set in the pp yaml (made an optional key)
  • updates fre/list/list_pp_components_script
  • updates fre/app/regrid_xy/regrid_xy.py
  • update list_pp_component test
  • update documentation: listtools.rst, pp_yaml.rst
  • cleans up some other out-of date yaml structure

Issue ticket number and link (if applicable)

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback
  • No print statements; all user-facing info uses logging module

Note: If you are a code maintainer updating the tag or releasing a new fre-cli version, please use the release_procedure.md template. To quickly use this template, open a new pull request, choose your branch, and add ?template=release_procedure.md to the end of the url.

Dana Singh added 4 commits April 13, 2026 16:30
@singhd789
Copy link
Copy Markdown
Contributor Author

Validation error related to this PR: NOAA-GFDL/gfdl_msd_schemas#50

@singhd789 singhd789 changed the title #847 Update fre list pp-components Update logic where postprocess_on and analysis_on is used Apr 14, 2026
@singhd789
Copy link
Copy Markdown
Contributor Author

Note: I thiiiiiink these are all the places postprocess_on and analysis_on are used in the fre-cli (besides yaml files). Since the keys would be optional in the yaml files, it's still ok that the key is defined.

@singhd789 singhd789 requested review from ceblanton and ilaflott April 14, 2026 18:32
@singhd789 singhd789 marked this pull request as ready for review April 14, 2026 18:33
Comment thread fre/pp/configure_script_yaml.py
Copy link
Copy Markdown
Contributor

@ceblanton ceblanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't believe we're doing so many relatively drastic changes.. this and the name changes together. We sure are bold!

This looks great and I think would pass also except for the case where the analysis yaml has no items.

Comment thread docs/tools/listtools.rst Outdated
Comment thread fre/pp/configure_script_yaml.py Outdated
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2026

Codecov Report

❌ Patch coverage is 63.15789% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.14%. Comparing base (80ed3f1) to head (4792f03).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
fre/app/regrid_xy/regrid_xy.py 0.00% 4 Missing ⚠️
fre/pp/configure_script_yaml.py 83.33% 2 Missing ⚠️
fre/list_/list_pp_components_script.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #861   +/-   ##
=======================================
  Coverage   84.14%   84.14%           
=======================================
  Files          71       71           
  Lines        4975     4975           
=======================================
  Hits         4186     4186           
  Misses        789      789           
Flag Coverage Δ
unittests 84.14% <63.15%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
fre/list_/list_pp_components_script.py 95.65% <66.66%> (ø)
fre/pp/configure_script_yaml.py 89.74% <83.33%> (ø)
fre/app/regrid_xy/regrid_xy.py 13.70% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fae6172...4792f03. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread fre/pp/tests/test_configure_script_yaml.py
Copy link
Copy Markdown
Contributor

@ceblanton ceblanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you for the analysis tests (that I will touch in #868 and make sure still work)

@singhd789 singhd789 merged commit dea2038 into NOAA-GFDL:main Apr 16, 2026
8 checks passed
@singhd789 singhd789 linked an issue Apr 16, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set default to postprocess_on and analysis_on

3 participants