Skip to content

Add test case for refineDiag and preAnalysis capability in workflow#222

Open
Copilot wants to merge 7 commits intomainfrom
copilot/add-test-case-refinediag-preanalysis
Open

Add test case for refineDiag and preAnalysis capability in workflow#222
Copilot wants to merge 7 commits intomainfrom
copilot/add-test-case-refinediag-preanalysis

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 3, 2026

Adds YAML configuration and dummy scripts to exercise the refineDiag and preAnalysis code paths in the container test workflow.

Describe your changes

for_gh_runner/yaml_workflow/settings.yaml

  • Enable do_refinediag: True and do_preanalysis: True (were both False)
  • Add refinediag.atmos block pointing to $CYLC_WORKFLOW_RUN_DIR/etc/refineDiag/dummy.csh with atmos_month input
  • Add preanalysis.vitals block pointing to $CYLC_WORKFLOW_RUN_DIR/etc/preAnalysis/dummy.csh with atmos_month input
  preanalysis:
    vitals:
      script:                "$CYLC_WORKFLOW_RUN_DIR/etc/preAnalysis/dummy.csh"
      input:                 ['atmos_month']
      do_preanalysis:        True
  refinediag:
    atmos:
      script:                "$CYLC_WORKFLOW_RUN_DIR/etc/refineDiag/dummy.csh"
      input:                 ['atmos_month']
      output:                ['atmos_refined']
      do_refinediag:         True

etc/preAnalysis/dummy.csh (new)

  • Minimal no-op preAnalysis script analogous to the existing etc/refineDiag/dummy.csh; exits 0 so the workflow task succeeds

Issue ticket number and link (if applicable)

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback
  • No print statements; all user-facing info uses logging module

Manual Pipeline Run Details

Was the manual pipeline (test_cloud_runner) triggered for this PR?

  • Yes
  • No

Result of manual pipeline run:

Not yet triggered. The test_cloud_runner pipeline should be run to validate that the refineDiag and preAnalysis tasks execute and succeed end-to-end in the container.

How to trigger the manual pipeline:

The test_cloud_runner pipeline is not automatically associated as a required check with the PR; it must be triggered to test changes in a full post-processing run.

To trigger the manual pipeline:

  1. Follow the link to the test_cloud_runner actions tab here

    • you should see "This workflow has a workflow_dispatch event trigger"
  2. Click the dropdown "Run workflow":

    a. If trying to merge from a branch on fre-workflows: choose branch from the first drop down, leave the next 2 inputs blank, and choose the fre-cli branch to test

    b. If trying to merge from a fre-workflows fork: can skip first branch selection, input the fork name (ex: [user]/fre-workflows), input the fork's branch name, and choose the fre-cli branch to test

  3. Click "Run workflow"

Note: you may need to reload the page to see your running workflow.

Copilot AI changed the title [WIP] Add test case for refineDiag and preAnalysis capability in workflow Add test case for refineDiag and preAnalysis capability in workflow Apr 3, 2026
Copilot AI requested a review from ilaflott April 3, 2026 20:08
@singhd789
Copy link
Copy Markdown
Contributor

singhd789 commented Apr 9, 2026

Looking at what copilot did and what I was also working on for the cloud, they look pretty similar! I'm fixing up paths for the cloud in my PR though. (and adding refinediag)

Could be good to divide and conquer - this PR could be for a local test and I'll push up the remote test 👀

@ilaflott ilaflott marked this pull request as ready for review April 10, 2026 21:47
Copy link
Copy Markdown
Member

@ilaflott ilaflott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

largely what we want, ready for a real review

@ilaflott ilaflott requested review from ceblanton and singhd789 April 10, 2026 21:48
@ilaflott
Copy link
Copy Markdown
Member

Looking at what copilot did and what I was also working on for the cloud, they look pretty similar! I'm fixing up paths for the cloud in my PR though. (and adding refinediag)

Could be good to divide and conquer - this PR could be for a local test and I'll push up the remote test 👀

oh i was getting schema errors so i made this to plug the gap. sorry i just saw this

@ilaflott
Copy link
Copy Markdown
Member

clearly this only partially addresses #216 and if @singhd789 wants to supersede it with another PR i am completely fine with that, this was almost entirely motivated by testing NOAA-GFDL/fre-cli#830

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add test case for refineDiag and preAnalysis capability in workflow

3 participants