STATIC FILES: Read combined yaml directly for static source information#50
Merged
STATIC FILES: Read combined yaml directly for static source information#50
Conversation
added 8 commits
March 6, 2025 14:33
…c sources defined - `DO_REGRID_STATIC` - `DO_NATIVE_STATIC`
- when looping through static - there could be sources or offline_source - when offine_source --> source = None
added 4 commits
March 13, 2025 17:13
- update remap-pp-components to load and read yaml file - update flow.cylc to actually use combine-statics script
Contributor
Author
|
Note: regrid-xy |
Contributor
|
Looks good! Thank you especially for getting rid of the rose parsing from form-task-parameters. One down, and a few to go :) |
- remove "rewrite" - in addressing a plyint message about `form_remap_dep`, I messed up the flow.cylc b/c the arguments were not in the right order (corrected!)
ceblanton
reviewed
Apr 1, 2025
| # else | ||
| # echo "$(ls $outputDir/$comp)" | ||
| # fi | ||
|
|
Contributor
There was a problem hiding this comment.
Thanks so much Dana for this big update. It works well, hooray!
A commented debug code block here is a victimless crime in this shell script whose days are numbered...
ceblanton
approved these changes
Apr 1, 2025
Contributor
ceblanton
left a comment
ceblanton
left a comment
There was a problem hiding this comment.
Fantastic! Thank you! I tested it and it worked as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files rewritten to parse yaml file directly instead of rose-app.conf:
remap-pp-componentsform_task_parameters.pyform_remap_dep.pyStatic, per-component, implementation also includes:
DO_STATICSfrom flow.cylcDO_REGRID_STATICandDO_NATIVE_STATIC