Add Phase 2.5 equivalence testing infrastructure (CI + comparison script)#19
Closed
Add Phase 2.5 equivalence testing infrastructure (CI + comparison script)#19
Conversation
ilaflott
force-pushed
the
copilot/phase-2-5-equivalence-testing
branch
from
ab87897 to
dc43d3a
Compare
Copilot
AI
changed the title
[WIP] Add equivalence testing with fre-cli for fremorizer
Add Phase 2.5 equivalence testing infrastructure (CI + comparison script)
Apr 14, 2026
ilaflott
force-pushed
the
copilot/phase-2-5-equivalence-testing
branch
3 times, most recently
from
6edc010 to
cf497d0
Compare
Create .github/workflows/equivalence_test.yml that: - Checks out both fremorizer and fre-cli with submodules - Sets up miniforge with conda-forge and noaa-gfdl channels - Creates separate conda environments for each tool - Runs comparison script against shared test fixtures - Uploads equivalence report as CI artifact Create fremorizer/tests/equivalence/compare_with_fre_cli.py that: - Runs equivalent CLI commands through both tools (fremor vs fre cmor) - Compares output directory structures - Deep-compares netCDF files (dimensions, variables, attributes, data) - Generates a markdown equivalence report - Covers basic CMORization run, varlist variants, and find subtool - Handles known acceptable differences (timestamps, UUIDs, etc.) Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/5d037b88-43a4-4d27-8b71-8f66a467e829 Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
- Use parenthesized line continuation for multi-line path construction - Wrap ncgen3 call with a descriptive FileNotFoundError message - Rename ambiguous loop variable 'l' to 'line' Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/5d037b88-43a4-4d27-8b71-8f66a467e829 Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
…checkouts - Remove 'Checkout fre-cli' step; install fre-cli from noaa-gfdl conda channel instead - Drop submodules: recursive from fremorizer checkout - Add explicit checkout steps for cmip6-cmor-tables (pcmdi) and cmip7-cmor-tables (WCRP-CMIP) into their correct paths under fremorizer/tests/test_files/ Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/339a91ec-f811-48a0-bc0b-7048d0eee2ed Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
ilaflott
force-pushed
the
copilot/phase-2-5-equivalence-testing
branch
from
cf497d0 to
e8dc570
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19 +/- ##
=======================================
Coverage 93.74% 93.74%
=======================================
Files 9 9
Lines 1199 1199
=======================================
Hits 1124 1124
Misses 75 75 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Member
|
nah |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checkout fre-clistep;conda install noaa-gfdl::fre-cliinsteadsubmodules: recursive; add explicit checkouts forcmip6-cmor-tablesandcmip7-cmor-tables