Add WCRP compliance check pipeline using cc-plugin-wcrp#67
Merged
Conversation
7a96095 to
4b85bc8
Compare
Copilot
AI
changed the title
[WIP] Check pipeline outputs against WCRP cc-plugin
Add WCRP compliance check pipeline using cc-plugin-wcrp
Apr 14, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #67 +/- ##
=======================================
Coverage 93.78% 93.78%
=======================================
Files 9 9
Lines 1206 1206
=======================================
Hits 1131 1131
Misses 75 75 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/467572fc-cbb2-4eb8-9473-3a23cfb8f9bb Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/9a306387-45f9-4cd4-a4c3-16157ba3e367 Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
…irst Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/9a306387-45f9-4cd4-a4c3-16157ba3e367 Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
dfdb851 to
5231a36
Compare
ilaflott
requested changes
Apr 14, 2026
Member
ilaflott
left a comment
There was a problem hiding this comment.
make sure all the testing outputs are being collected, see comments
…ther' category Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/077064d2-edaa-4d2e-9c77-e1fb6de5f59f Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
Contributor
Author
All addressed in e3d729d — now collecting outputs from all four test files (run_subtool, further_examples, yamler dry_run_false, CLI). 14 total CMOR outputs gathered (12 CMIP6, 2 CMIP7), 2 non-compliant files skipped. |
Member
|
awyiss |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds a GitHub Actions workflow (
wcrp_compliance_check.yml) that runs cc-plugin-wcrp WCRP compliance checks against all NetCDF outputs generated by the test suite.Key changes
wcrp_compliance_check.yml): New CI pipeline that runs on PRs andworkflow_dispatch. Uses the repository'senvironment.yamlfor conda dependencies. Runs all output-generating tests in a single pytest invocation, gathers the CMOR outputs, then validates them withcompliance-checker --test=wcrp_cmip6.gather_test_outputs.sh): Reusable script that collects NetCDF test outputs from hardcoded output directories and the pytest--basetempdirectory, categorizes them as CMIP6 or CMIP7, and skips uncategorized files (e.g. statics) that are not expected to be compliant.Pipeline structure
pytestinvocation with--basetemp=tmp/pytest_basetempto preserve temporary artifacts:test_cmor_run_subtool.py— outputs tofremorizer/tests/test_files/outdirtest_cmor_run_subtool_further_examples.py— outputs tofremorizer/tests/test_files/outdir_ppan_onlytest_cmor_yamler_subtool.py::test_cmor_yaml_subtool_dry_run_false— outputs to basetemptest_cli.py— outputs to basetemp (CMIP6 and CMIP7 run cases)wcrp_cmip6checks on CMIP6 and CMIP7 outputs, generating text and JSON reports.Bug fixes
set -e+((var++))from 0 arithmetic gotcha ingather_test_outputs.sh— replaced withvar=$((var + 1)).--basetempfrom being wiped between separate pytest calls.Checklist before requesting a review