Conversation
Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/fcd4078a-1b4b-471f-b478-83f5ce1d1628 Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
…in conftest.py Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/fcd4078a-1b4b-471f-b478-83f5ce1d1628 Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/fcd4078a-1b4b-471f-b478-83f5ce1d1628 Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
…e exists Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/fcd4078a-1b4b-471f-b478-83f5ce1d1628 Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/fcd4078a-1b4b-471f-b478-83f5ce1d1628 Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
…ed args Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/fcd4078a-1b4b-471f-b478-83f5ce1d1628 Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
…g DNE Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/fcd4078a-1b4b-471f-b478-83f5ce1d1628 Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
… list Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/fcd4078a-1b4b-471f-b478-83f5ce1d1628 Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
…riable not in table Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/fcd4078a-1b4b-471f-b478-83f5ce1d1628 Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
…n run Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/fcd4078a-1b4b-471f-b478-83f5ce1d1628 Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
…ta comparison Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/fcd4078a-1b4b-471f-b478-83f5ce1d1628 Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
…t fixtures Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/fcd4078a-1b4b-471f-b478-83f5ce1d1628 Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
…— metadata comparison Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/fcd4078a-1b4b-471f-b478-83f5ce1d1628 Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/fcd4078a-1b4b-471f-b478-83f5ce1d1628 Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/fcd4078a-1b4b-471f-b478-83f5ce1d1628 Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
…se2 data comparison Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/fcd4078a-1b4b-471f-b478-83f5ce1d1628 Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
…— all 13 CMIP7 tests pass Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/fcd4078a-1b4b-471f-b478-83f5ce1d1628 Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
…fo/table_id assertions Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/fcd4078a-1b4b-471f-b478-83f5ce1d1628 Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #87 +/- ##
==========================================
+ Coverage 95.03% 95.19% +0.15%
==========================================
Files 10 10
Lines 1310 1310
==========================================
+ Hits 1245 1247 +2
+ Misses 65 63 -2
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
ilaflott
left a comment
There was a problem hiding this comment.
for fremorizer/tests/test_cmor_run_subtool_further_examples.py, it's time to make these CMIP7 flavored too.
- DO THIS FIRST! the approach in this
further_examplesversion of thefremor runtests could be improved with slight refactoring- there's case-specific logic, is there a
pytestcanon way of doing this withinparam? - the
ncgencall -->fixture - the
def _cleanupfunction --> remove and leverage temporary paths instead - sometimes the temporary path thing makes debugging tests annoying, leave a note somewhere with how to call
pytestand not have it clobber the temporary working directories
- there's case-specific logic, is there a
- now, enact plan, take the same approach as your last iteration- write the CMIP7 flavored tests, skip them, then get them to pass one-by-one, making your commits atomic.
- AFTER EVERYTHING ELSE touch up the
pylintscore, it needs to be above9.6, but do not undertake any grand efforts to meet the threshold, at this point all your edits must leave results and functioning largely invariant
| _cleanup() | ||
|
|
||
| def test_git_cleanup(): | ||
| def test_exp_config_cleanup(): |
There was a problem hiding this comment.
can simply remove this unless there's a good reason
There was a problem hiding this comment.
Removed in e85f76f. The autouse _write_exp_configs fixture in conftest handles restoring the experiment config, so test_exp_config_cleanup is no longer needed.
…rted for mock archive vars) Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/ef42d003-f83d-4993-b546-fa0a03e41dac Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
…ding, disable line-too-long for config dicts Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/ef42d003-f83d-4993-b546-fa0a03e41dac Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
All done: Refactoring (
CMIP7 tests ( Pylint ( |
Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/ef42d003-f83d-4993-b546-fa0a03e41dac Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
… output glob, remove xfail — all 3 tests pass Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/5dfb8553-ec4f-4f7b-b00e-1ad53d2f12d9 Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
…nd unused CMIP7 constants Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/de54c9d9-0a77-46c2-9208-5f8ae457c536 Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
…tests initially @Skip Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/de54c9d9-0a77-46c2-9208-5f8ae457c536 Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
…lai all pass with g999 grid_label Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/de54c9d9-0a77-46c2-9208-5f8ae457c536 Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
…(pylint 10/10) Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/de54c9d9-0a77-46c2-9208-5f8ae457c536 Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
…g CMIP6 structure, all 8 cases, conditional skip in body Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/de54c9d9-0a77-46c2-9208-5f8ae457c536 Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
…ecks where Y is a dict
… that didnt actually do anything
… crush resultant quote consistency errors everywhere whilst inspecting for hidden slop
ilaflott
left a comment
There was a problem hiding this comment.
two CMIP7 "further_examples" tests skipped for now:
gppLut/CMIP7_landnot working, WCRP-CMIP/cmip7-cmor-tables#76ch4globalno longer exists in CMIP7 --> likely is included just not under the same name
this will help QA the other features.
test_cmor_run_subtool_further_examples.py(keep CMIP6-only)test_cmor_run_subtool_cmip7_further_examples.pymirroring CMIP6 file structuretest_case_cmip7function with all 8 casespytest.skip()in the body for cases that cannot yet passatmos_ta_g999— PASSESatmosChem_ch4global_g999— SKIPPED (variable doesn't exist in any CMIP7 table)land_gppLut_g999— SKIPPED (CMIP7 landuse coordinate incompatible with mock data)atmos_cl_g999— PASSESatmos_mc_g999— PASSESocean_so_g999— PASSESocean_sos_g999— PASSESland_lai_g999— PASSES