Conversation
* add a method to get the orientation of the edge within the face_edge_connectivity. * fix bug for face_edge_connectivity with FillValue
this commit partially reverts NOAA-ORR-ERD@fd89162. It removes the cython-based lookup and uses the method proposed by @Huite in NOAA-ORR-ERD#61 (comment) instead.
use vectorized algorithms for build_edges, build_edge_coordinates and build_face_coordinates and account for missing values
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up of #61 and adds the algorithm to compute the dual mesh for the nodes. It uses the functionalities from #61 (which is why it's a draft PR so far) such that we create the dual mesh for the nodes from the dual mesh for the edges. Roughly spoken, it works like this:
node_edge_connectivity(similarly to the algorithm proposed by @Huite for theedge_face_connectivityin Add algorithm for dual mesh creation for edges #61 (comment))node_edge_connectivity: if the cell in the corresponding dual edge mesh is triangular, add the center of the edge as another node.The anti-clockwise ordering results from the anti-clockwise ordering of the dual edge mesh.
I head to use cython for step 3 and 4 as I did not know how to best vectorize this.