Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add realization config for Lasam #820

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

stcui007
Copy link
Contributor

@stcui007 stcui007 commented May 16, 2024

This PR create several realization configs for LGAR-C submodule in combinations with several other submodules to run within ngen at CONUS scale. The realization configs were initially located in the data/baseline, then moved to data/baseline/realizations based on suggestions in Issue#757

Additions

Realization configurations including LGAR-C

Removals

Changes

Testing

Run ngen in MPI with all the realization configs in this PR.

Screenshots

Notes

To run LGAR-C, a different initial configuration for SMP, config_layered.txt than the conceptual initial config for CFE is needed. In this case, a single initial config for SMP is used for all CONUS at Ahmad suggestion. Additional coding for SMP submodule is needed to accomodate more realistic model, which has been discussed within Ahmad's team. This only affects the realization configs that using SMP.

Todos

Test run needed

Checklist

  • [x ] PR has an informative and human-readable title
  • [x ] Changes are limited to a single goal (no scope creep)
  • [x ] Code can be automatically merged (no conflicts)
  • [x ] Code follows project standards (link if applicable)
  • [x ] Passes all existing automated tests
  • [x ] Any change in functionality is tested
  • [x ] New functions are documented (with a description, list of inputs, and expected output)
  • [x ] Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist (automated report can be put here)

  1. Passing all automated tests.

Target Environment support

  • [x ] Linux

@stcui007 stcui007 reopened this Jun 27, 2024
@stcui007 stcui007 marked this pull request as ready for review July 2, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant