Implementing a BMI mass balance checking protocol#909

Merged

hellkite500 merged 29 commits intoNOAA-OWP:masterfrom

hellkite500:bmi-mass-balance

Oct 27, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implementing a BMI mass balance checking protocol#909

Implementing a BMI mass balance checking protocol#909
hellkite500 merged 29 commits intoNOAA-OWP:masterfrom
hellkite500:bmi-mass-balance

Commits on Sep 17, 2025

feat(bmi): Interface for generic BMI protocols

feat(mass_balance): define the bmi mass balance protocol

feat(bmi): light container for BMI protocol objects

build(ngen_bmi_protocols): add protocol library to build

test(bmi_protocols): add mock for BMI protocol testing

test(bmi_c): update bmi C test model code to implement the mass balance protocol semantics

test(bmi_mass_balance): Test the protocol via the C and multi formulation tests

feat(ngen): add mass balance check for all bmi modules during runtime

Commits on Sep 27, 2025

dep(expected): vendor expected-lite header lib for bmi protocols

feat(bmi-protocols)!: v0.2 of the protocols lib using expected semantics for error handling

fix: update ngen and tests for v0.2 of bmi protocols

Commits on Oct 23, 2025

feat(protocol)!: make the protocol a pure interface; implement is_supported()

fix(mass_balance): treat all negative frequency settings the same

fix(mass_balance): don't check support with null model

fix(mass_balance): handle potential NaN tolernace

fix(protocols): better default handling; add missing return

chore(mass_balance): alignment/padding friendly member ordering

doc(mass_balance): update docstrings

doc(protocols): update docstrings

test(test_bmi_cpp): implement mass balance protocol in cpp test model

test(bmi_protocols): add standalone mass balance protocol unit tests

test: point formulation tests to use same protocol mock

fix(test): use older compatible static struct initialization in mock

ci(test_and_validate): add bmi protocol unit tests to workflow

Commits on Oct 24, 2025

chore: add the boost software license for expected

fix(build): fix expected.tweak macro name

fix(mass_balance): NaN in model vars should trigger mass balance error/warning

fix(mass_balance): avoid div-by-zero, don't check mass balance with frequency 0

fix(mass_balance): use conditinonal macro for nodiscard attribute (c++17)

Implementing a BMI mass balance checking protocol#909hellkite500 merged 29 commits intoNOAA-OWP:masterNOAA-OWP/ngen:masterfrom hellkite500:bmi-mass-balancehellkite500/ngen:bmi-mass-balanceCopy head branch name to clipboard

Commits

Commits on Sep 17, 2025

Commits on Sep 27, 2025

Commits on Oct 23, 2025

Commits on Oct 24, 2025

Implementing a BMI mass balance checking protocol#909
hellkite500 merged 29 commits intoNOAA-OWP:masterfrom
hellkite500:bmi-mass-balance